From 6a0f7b0713ae1846ca8d54807cfca4aeb3878488 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Fri, 15 May 2020 10:58:09 -0700 Subject: [PATCH] Fix exception when disposing Terminal twice Fixes #2933 --- src/browser/services/RenderService.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/browser/services/RenderService.ts b/src/browser/services/RenderService.ts index df4cf443..ca8f9102 100644 --- a/src/browser/services/RenderService.ts +++ b/src/browser/services/RenderService.ts @@ -55,6 +55,9 @@ export class RenderService extends Disposable implements IRenderService { @IBufferService bufferService: IBufferService ) { super(); + + this.register({ dispose: () => this._renderer.dispose() }); + this._renderDebouncer = new RenderDebouncer((start, end) => this._renderRows(start, end)); this.register(this._renderDebouncer); @@ -137,7 +140,6 @@ export class RenderService extends Disposable implements IRenderService { } public dispose(): void { - this._renderer.dispose(); super.dispose(); }