From 3ce552cdec206e5e6ee7e5782740e9e90861698c Mon Sep 17 00:00:00 2001
From: Daniel Imms <daimms@microsoft.com>
Date: Tue, 22 Oct 2019 06:33:07 -0700
Subject: [PATCH] Warn don't throw when open is called on unattached element

Related microsoft/vscode#83016
---
 src/Terminal.ts        | 4 ++++
 src/public/Terminal.ts | 3 ---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/Terminal.ts b/src/Terminal.ts
index 597c14cd..3e7e55ca 100644
--- a/src/Terminal.ts
+++ b/src/Terminal.ts
@@ -508,6 +508,10 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp
       throw new Error('Terminal requires a parent element.');
     }
 
+    if (!document.body.contains(parent)) {
+      this._logService.warn('Terminal.open was called on an element that was not attached to the DOM');
+    }
+
     this._document = this._parent.ownerDocument;
 
     // Create main element container
diff --git a/src/public/Terminal.ts b/src/public/Terminal.ts
index fe34cb36..c167bed8 100644
--- a/src/public/Terminal.ts
+++ b/src/public/Terminal.ts
@@ -56,9 +56,6 @@ export class Terminal implements ITerminalApi {
     this._core.resize(columns, rows);
   }
   public open(parent: HTMLElement): void {
-    if (!document.body.contains(parent)) {
-      throw new Error('open must be called on an element that is attached to the DOM');
-    }
     this._core.open(parent);
   }
   public attachCustomKeyEventHandler(customKeyEventHandler: (event: KeyboardEvent) => boolean): void {