From 4f18717940e5be633228c1dabd81d0dd78f19a82 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Fri, 23 Nov 2018 07:49:35 -0800 Subject: [PATCH] Improve handling of default values --- src/core/TypedArrayUtils.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/core/TypedArrayUtils.ts b/src/core/TypedArrayUtils.ts index 2e85400c..6e1a3630 100644 --- a/src/core/TypedArrayUtils.ts +++ b/src/core/TypedArrayUtils.ts @@ -12,7 +12,7 @@ type TypedArray = Uint8Array | Uint16Array | Uint32Array | Uint8ClampedArray | Int8Array | Int16Array | Int32Array | Float32Array | Float64Array; -export function fill(array: T, value: number, start: number = 0, end?: number | undefined): T { +export function fill(array: T, value: number, start?: number, end?: number): T { // all modern engines that support .fill if (array.fill) { return array.fill(value, start, end) as T; @@ -20,7 +20,7 @@ export function fill(array: T, value: number, start: numbe return fillFallback(array, value, start, end); } -export function fillFallback(array: T, value: number, start: number = 0, end?: number | undefined): T { +export function fillFallback(array: T, value: number, start: number = 0, end: number = array.length): T { // safari and IE 11 // since IE 11 does not support Array.prototype.fill either // we cannot use the suggested polyfill from MDN @@ -29,9 +29,6 @@ export function fillFallback(array: T, value: number, star return array; } start = (array.length + start) % array.length; - if (end === undefined) { - end = array.length; - } if (end >= array.length) { end = array.length; } else {