From 4d05905736cacf08f65fce79a373eaf3f9b9add3 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Sun, 30 Oct 2022 18:11:24 -0700 Subject: [PATCH] Polish --- addons/xterm-addon-canvas/typings/xterm-addon-canvas.d.ts | 4 +++- addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts | 4 +++- src/browser/renderer/shared/TextureAtlas.ts | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/addons/xterm-addon-canvas/typings/xterm-addon-canvas.d.ts b/addons/xterm-addon-canvas/typings/xterm-addon-canvas.d.ts index 73eff529..c983825c 100644 --- a/addons/xterm-addon-canvas/typings/xterm-addon-canvas.d.ts +++ b/addons/xterm-addon-canvas/typings/xterm-addon-canvas.d.ts @@ -17,7 +17,9 @@ declare module 'xterm-addon-canvas' { */ public readonly onChangeTextureAtlas: IEvent; - // TODO: Doc + /** + * An event that is fired when the a new page is added to the texture atlas. + */ public readonly onAddTextureAtlasCanvas: IEvent; constructor(); diff --git a/addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts b/addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts index a6afd2ac..79108e0d 100644 --- a/addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts +++ b/addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts @@ -22,7 +22,9 @@ declare module 'xterm-addon-webgl' { */ public readonly onChangeTextureAtlas: IEvent; - // TODO: Doc + /** + * An event that is fired when the a new page is added to the texture atlas. + */ public readonly onAddTextureAtlasCanvas: IEvent; constructor(preserveDrawingBuffer?: boolean); diff --git a/src/browser/renderer/shared/TextureAtlas.ts b/src/browser/renderer/shared/TextureAtlas.ts index 146aa1b5..22c33c50 100644 --- a/src/browser/renderer/shared/TextureAtlas.ts +++ b/src/browser/renderer/shared/TextureAtlas.ts @@ -137,7 +137,7 @@ export class TextureAtlas implements ITextureAtlas { if (this._pages.length === 4 || this._pages.length === 7) { this._increaseTextureSize(); } - // TODO: Clear all pages and restart if the maximum page count is reached + // TODO: Ensure pages aren't created beyond the maximum supported const newPage = new AtlasPage(this._document, this._textureSize); this._pages.push(newPage); this._activePages.push(newPage);