From 4c0c2559c33a02d147daedf80a45d82d6f543406 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri, 13 Jun 2025 08:19:31 -0700 Subject: [PATCH] Add note about reverse tabnapping Fixes #3634 --- addons/addon-web-links/typings/addon-web-links.d.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/addons/addon-web-links/typings/addon-web-links.d.ts b/addons/addon-web-links/typings/addon-web-links.d.ts index 4ae4934e..61d6e5f9 100644 --- a/addons/addon-web-links/typings/addon-web-links.d.ts +++ b/addons/addon-web-links/typings/addon-web-links.d.ts @@ -14,6 +14,10 @@ declare module '@xterm/addon-web-links' { /** * Creates a new web links addon. * @param handler The callback when the link is called. + * + * Note that this may not work when the terminal is hosted inside an iframe, + * in that case provide a custom handler in that case being mindful of + * possible security issues like reverse tabnapping. * @param options Options for the link provider. */ constructor(handler?: (event: MouseEvent, uri: string) => void, options?: ILinkProviderOptions);