From 41e97ec04287a18318eb81607ceb940e03b91bb8 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 1 Aug 2023 07:43:27 -0700 Subject: [PATCH] Always render cursor even if model didn't change This ensures underline/bar cursors get rendered --- addons/xterm-addon-webgl/src/RectangleRenderer.ts | 4 +--- addons/xterm-addon-webgl/src/WebglRenderer.ts | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/addons/xterm-addon-webgl/src/RectangleRenderer.ts b/addons/xterm-addon-webgl/src/RectangleRenderer.ts index 5f5e0475..4706b442 100644 --- a/addons/xterm-addon-webgl/src/RectangleRenderer.ts +++ b/addons/xterm-addon-webgl/src/RectangleRenderer.ts @@ -242,11 +242,9 @@ export class RectangleRenderer extends Disposable { } } vertices.count = rectangleCount; - - this._updateCursor(model); } - private _updateCursor(model: IRenderModel): void { + public updateCursor(model: IRenderModel): void { const vertices = this._verticesCursor; const cursor = model.cursor; if (!cursor || cursor.style === 'block') { diff --git a/addons/xterm-addon-webgl/src/WebglRenderer.ts b/addons/xterm-addon-webgl/src/WebglRenderer.ts index c58818f5..b74aada9 100644 --- a/addons/xterm-addon-webgl/src/WebglRenderer.ts +++ b/addons/xterm-addon-webgl/src/WebglRenderer.ts @@ -523,6 +523,7 @@ export class WebglRenderer extends Disposable implements IRenderer { if (modelUpdated) { this._rectangleRenderer!.updateBackgrounds(this._model); } + this._rectangleRenderer!.updateCursor(this._model); } /**