diff --git a/src/Terminal.ts b/src/Terminal.ts index 597c14cd..3e7e55ca 100644 --- a/src/Terminal.ts +++ b/src/Terminal.ts @@ -508,6 +508,10 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp throw new Error('Terminal requires a parent element.'); } + if (!document.body.contains(parent)) { + this._logService.warn('Terminal.open was called on an element that was not attached to the DOM'); + } + this._document = this._parent.ownerDocument; // Create main element container diff --git a/src/public/Terminal.ts b/src/public/Terminal.ts index fe34cb36..c167bed8 100644 --- a/src/public/Terminal.ts +++ b/src/public/Terminal.ts @@ -56,9 +56,6 @@ export class Terminal implements ITerminalApi { this._core.resize(columns, rows); } public open(parent: HTMLElement): void { - if (!document.body.contains(parent)) { - throw new Error('open must be called on an element that is attached to the DOM'); - } this._core.open(parent); } public attachCustomKeyEventHandler(customKeyEventHandler: (event: KeyboardEvent) => boolean): void {