From 39037ee806077535e69e6f396536dc9eb9c15a9c Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Sat, 31 Jan 2026 10:20:44 -0800 Subject: [PATCH] Prefer startsWith over indexOf === 0 Faster and make code clearer --- src/common/InputHandler.ts | 2 +- src/common/input/XParseColor.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/common/InputHandler.ts b/src/common/InputHandler.ts index 1bb923e6..eb83cf8a 100644 --- a/src/common/InputHandler.ts +++ b/src/common/InputHandler.ts @@ -1780,7 +1780,7 @@ export class InputHandler extends Disposable implements IInputHandler { * @param term The terminal name to evaluate */ private _is(term: string): boolean { - return (this._optionsService.rawOptions.termName + '').indexOf(term) === 0; + return (this._optionsService.rawOptions.termName + '').startsWith(term); } /** diff --git a/src/common/input/XParseColor.ts b/src/common/input/XParseColor.ts index fd23ec4b..ae4a3bca 100644 --- a/src/common/input/XParseColor.ts +++ b/src/common/input/XParseColor.ts @@ -24,7 +24,7 @@ export function parseColor(data: string): [number, number, number] | undefined { if (!data) return; // also handle uppercases let low = data.toLowerCase(); - if (low.indexOf('rgb:') === 0) { + if (low.startsWith('rgb:')) { // 'rgb:' specifier low = low.slice(4); const m = RGB_REX.exec(low); @@ -36,7 +36,7 @@ export function parseColor(data: string): [number, number, number] | undefined { Math.round(parseInt(m[3] || m[6] || m[9] || m[12], 16) / base * 255) ]; } - } else if (low.indexOf('#') === 0) { + } else if (low.startsWith('#')) { // '#' specifier low = low.slice(1); if (HASH_REX.exec(low) && [3, 6, 9, 12].includes(low.length)) {