From 38d08873bc920f89f2fcdc062c39f63ef0669411 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 13 Jul 2016 20:34:43 -0700 Subject: [PATCH] Don't finalize composition on modifier key presses --- src/xterm.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/xterm.js b/src/xterm.js index 8166c545..30bf987f 100644 --- a/src/xterm.js +++ b/src/xterm.js @@ -2627,7 +2627,10 @@ Terminal.prototype.keyDown = function(ev) { if (this.compositionHelper.isComposing || this.compositionHelper.isSendingComposition) { if (ev.keyCode === 229) { - // Continue composing + // Continue composing if the keyCode is the "composition character" + return; + } else if (ev.keyCode === 16 || ev.keyCode === 17 || ev.keyCode === 18) { + // Continue composing if the keyCode is a modifier key return; } else { // Finish composition immediately