Remove duplicate code and clean up after merge

This commit is contained in:
Jon Bockhorst
2020-02-13 00:07:07 -06:00
parent 258b084a62
commit 383e2ed46f
10 changed files with 31 additions and 62 deletions
+1 -1
View File
@@ -3,7 +3,7 @@
* @license MIT
*/
import { pollFor, getBrowserType, openTerminal } from './TestUtils';
import { pollFor, openTerminal, getBrowserType } from './TestUtils';
import { Browser, Page } from 'playwright';
const APP = 'http://127.0.0.1:3000/test';
+1 -2
View File
@@ -4,9 +4,8 @@
*/
import { assert } from 'chai';
import { ITerminalOptions } from 'xterm';
import { pollFor, openTerminal, getBrowserType } from './TestUtils';
import { Page, Browser } from 'playwright';
import { Browser, Page } from 'playwright';
import { IRenderDimensions } from 'browser/renderer/Types';
const APP = 'http://127.0.0.1:3000/test';
+1 -1
View File
@@ -31,7 +31,7 @@ export async function timeout(ms: number): Promise<void> {
return new Promise<void>(r => setTimeout(r, ms));
}
export async function openTerminal(page: puppeteer.Page, options: ITerminalOptions = {}): Promise<void> {
export async function openTerminal(page: playwright.Page, options: ITerminalOptions = {}): Promise<void> {
await page.evaluate(`window.term = new Terminal(${JSON.stringify(options)})`);
await page.evaluate(`window.term.open(document.querySelector('#terminal-container'))`);
if (options.rendererType === 'dom') {