From 377f88796f7a0846081b53d7217ec69d227b082e Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 24 Jan 2023 13:40:46 -0600 Subject: [PATCH] append accessibility tree as child, not as adjacent elt to terminal (#4383) --- src/browser/AccessibilityManager.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/browser/AccessibilityManager.ts b/src/browser/AccessibilityManager.ts index 1b244e6d..143e1a06 100644 --- a/src/browser/AccessibilityManager.ts +++ b/src/browser/AccessibilityManager.ts @@ -57,7 +57,6 @@ export class AccessibilityManager extends Disposable { ) { super(); this._accessibilityTreeRoot = document.createElement('div'); - this._terminal.element?.insertAdjacentElement('afterbegin', this._accessibilityTreeRoot); this._accessibilityTreeRoot.classList.add('xterm-accessibility'); this._accessibilityTreeRoot.tabIndex = 0; @@ -89,14 +88,13 @@ export class AccessibilityManager extends Disposable { if (!this._terminal.element) { throw new Error('Cannot enable accessibility before Terminal.open'); } + this._terminal.element.insertAdjacentElement('afterbegin', this._accessibilityTreeRoot); this._accessiblityBuffer = document.createElement('textarea'); this._accessiblityBuffer.ariaLabel = Strings.accessibilityBuffer; - this._accessiblityBuffer.readOnly = true; this._accessiblityBuffer.classList.add('xterm-accessibility-buffer'); this._accessiblityBuffer.addEventListener('focus', () => this._refreshAccessibilityBuffer()); - this._terminal.element.insertAdjacentElement('afterbegin', this._accessiblityBuffer); - + this._accessibilityTreeRoot.appendChild(this._accessiblityBuffer); this.register(this._renderRowsDebouncer); this.register(this._terminal.onResize(e => this._handleResize(e.rows)));