From 681ba4887fe40e39d2cc288ebcf6e6158f09a6eb Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Sat, 9 Sep 2023 07:11:32 -0700 Subject: [PATCH] Fix viewport error during term dispose Fixes #4775 --- src/browser/Viewport.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/browser/Viewport.ts b/src/browser/Viewport.ts index c6e8732f..a8e1a498 100644 --- a/src/browser/Viewport.ts +++ b/src/browser/Viewport.ts @@ -119,10 +119,10 @@ export class Viewport extends Disposable implements IViewport { private _innerRefresh(): void { if (this._charSizeService.height > 0) { - this._currentRowHeight = this._renderService.dimensions.device.cell.height / this._coreBrowserService.dpr; - this._currentDeviceCellHeight = this._renderService.dimensions.device.cell.height; + this._currentRowHeight = this._renderDimensions.device.cell.height / this._coreBrowserService.dpr; + this._currentDeviceCellHeight = this._renderDimensions.device.cell.height; this._lastRecordedViewportHeight = this._viewportElement.offsetHeight; - const newBufferHeight = Math.round(this._currentRowHeight * this._lastRecordedBufferLength) + (this._lastRecordedViewportHeight - this._renderService.dimensions.css.canvas.height); + const newBufferHeight = Math.round(this._currentRowHeight * this._lastRecordedBufferLength) + (this._lastRecordedViewportHeight - this._renderDimensions.css.canvas.height); if (this._lastRecordedBufferHeight !== newBufferHeight) { this._lastRecordedBufferHeight = newBufferHeight; this._scrollArea.style.height = this._lastRecordedBufferHeight + 'px';