From 22c4197a1d42ae76308f1d084370b2f975dc5981 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Mon, 2 Apr 2018 08:16:39 -0700 Subject: [PATCH 1/3] Lint addons --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 594c31a7..8d17b5cd 100644 --- a/package.json +++ b/package.json @@ -78,7 +78,7 @@ "start": "node demo/app", "prestart-zmodem": "npm run build", "start-zmodem": "node build/addons/zmodem/demo/app", - "lint": "tslint src/*.ts src/**/*.ts", + "lint": "tslint src/*.ts src/**/*.ts src/addons/**/*.ts", "test": "gulp test", "build:docs": "jsdoc -c jsdoc.json", "tsc": "tsc", From 768539a57c94891c3bc89a0a1823d0134fea3a5c Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Mon, 2 Apr 2018 08:17:44 -0700 Subject: [PATCH 2/3] Fix lint errors in attach --- src/addons/attach/attach.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/addons/attach/attach.ts b/src/addons/attach/attach.ts index b3b2e993..4a9668de 100644 --- a/src/addons/attach/attach.ts +++ b/src/addons/attach/attach.ts @@ -43,7 +43,7 @@ export function attach(term: Terminal, socket: WebSocket, bidirectional: boolean addonTerminal.__getMessage = function(ev: MessageEvent): void { let str; - if (typeof ev.data == 'object') { + if (typeof ev.data === 'object') { if (!myTextDecoder) { myTextDecoder = new TextDecoder(); } @@ -53,14 +53,14 @@ export function attach(term: Terminal, socket: WebSocket, bidirectional: boolean } else { let fileReader = new FileReader(); - fileReader.addEventListener('load', function() { + fileReader.addEventListener('load', () => { str = myTextDecoder.decode(this.result); displayData(str); }); fileReader.readAsArrayBuffer(ev.data); } - } else if (typeof ev.data == 'string') { - displayData(ev.data) + } else if (typeof ev.data === 'string') { + displayData(ev.data); } else { throw Error(`Cannot handle "${typeof ev.data}" websocket message.`); } @@ -73,7 +73,7 @@ export function attach(term: Terminal, socket: WebSocket, bidirectional: boolean * @param str String decoded by FileReader. * @param data The data of the EventMessage. */ - function displayData(str?: string, data?: string) { + function displayData(str?: string, data?: string): void { if (buffered) { addonTerminal.__pushToBuffer(str || data); } else { From 7d108999ff687fed5d50bee4271d66780208dc5e Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Mon, 16 Apr 2018 06:42:16 -0700 Subject: [PATCH 3/3] Fix lint --- src/addons/zmodem/zmodem.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/addons/zmodem/zmodem.ts b/src/addons/zmodem/zmodem.ts index 297ebe34..4f2f4a91 100644 --- a/src/addons/zmodem/zmodem.ts +++ b/src/addons/zmodem/zmodem.ts @@ -43,8 +43,7 @@ export interface IZmodemOptions { } function zmodemAttach(ws: WebSocket, opts: IZmodemOptions = {}): void { - var term = this; - + const term = this; const senderFunc = (octets: ArrayLike) => ws.send(new Uint8Array(octets)); let zsentry;