From 356a14bb161589cac72bbc3ccc7fa975ae9f7a3c Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Thu, 5 Oct 2017 20:30:09 -0700 Subject: [PATCH] Fix non-default backgrounds on left cell of wide/overlapping chars Fixes #1031 --- src/renderer/BaseRenderLayer.ts | 5 ----- src/renderer/TextRenderLayer.ts | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/renderer/BaseRenderLayer.ts b/src/renderer/BaseRenderLayer.ts index 8ff47503..aa6c7e92 100644 --- a/src/renderer/BaseRenderLayer.ts +++ b/src/renderer/BaseRenderLayer.ts @@ -224,11 +224,6 @@ export abstract class BaseRenderLayer implements IRenderLayer { * @param bold Whether the text is bold. */ protected drawChar(terminal: ITerminal, char: string, code: number, width: number, x: number, y: number, fg: number, bg: number, bold: boolean): void { - // Clear the cell next to this character if it's wide - if (width === 2) { - this.clearCells(x + 1, y, 1, 1); - } - let colorIndex = 0; if (fg < 256) { colorIndex = fg + 2; diff --git a/src/renderer/TextRenderLayer.ts b/src/renderer/TextRenderLayer.ts index 88930165..86159af3 100644 --- a/src/renderer/TextRenderLayer.ts +++ b/src/renderer/TextRenderLayer.ts @@ -146,6 +146,11 @@ export class TextRenderLayer extends BaseRenderLayer { } } + // Clear the cell next to this character if it's wide + if (width === 2) { + this.clearCells(x + 1, y, 1, 1); + } + // Draw background if (bg < 256) { this._ctx.save();