From 31686fda614a8c23955306857e365caec4d70a6a Mon Sep 17 00:00:00 2001 From: Simon Lamon Date: Sun, 31 Jul 2022 07:54:29 +0000 Subject: [PATCH] Fix tests --- src/headless/public/Terminal.test.ts | 7 ++----- src/headless/public/Terminal.ts | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/headless/public/Terminal.test.ts b/src/headless/public/Terminal.test.ts index 7f341b91..43aaf628 100644 --- a/src/headless/public/Terminal.test.ts +++ b/src/headless/public/Terminal.test.ts @@ -125,13 +125,10 @@ describe('Headless API Tests', function (): void { }); it('get options', () => { const options: ITerminalOptions = term.options; - strictEqual(options.cols, 80); - strictEqual(options.rows, 24); + strictEqual(options.lineHeight, 1); + strictEqual(options.cursorWidth, 1); }); it('set options', async () => { - const options: ITerminalOptions = term.options; - throws(() => options.cols = 40); - throws(() => options.rows = 20); term.options.scrollback = 1; strictEqual(term.options.scrollback, 1); term.options= { diff --git a/src/headless/public/Terminal.ts b/src/headless/public/Terminal.ts index 451d2372..efc0a8a1 100644 --- a/src/headless/public/Terminal.ts +++ b/src/headless/public/Terminal.ts @@ -7,11 +7,10 @@ import { IEvent } from 'common/EventEmitter'; import { BufferNamespaceApi } from 'common/public/BufferNamespaceApi'; import { ParserApi } from 'common/public/ParserApi'; import { UnicodeApi } from 'common/public/UnicodeApi'; -import { IBufferNamespace as IBufferNamespaceApi, IMarker, IModes, IParser, ITerminalAddon, IUnicodeHandling, Terminal as ITerminalApi } from 'xterm-headless'; +import { IBufferNamespace as IBufferNamespaceApi, IMarker, IModes, IParser, ITerminalAddon, ITerminalInitOnlyOptions, IUnicodeHandling, Terminal as ITerminalApi } from 'xterm-headless'; import { Terminal as TerminalCore } from 'headless/Terminal'; import { AddonManager } from 'common/public/AddonManager'; import { ITerminalOptions } from 'common/Types'; - /** * The set of options that only have an effect when set in the Terminal constructor. */ @@ -24,7 +23,7 @@ export class Terminal implements ITerminalApi { private _buffer: BufferNamespaceApi | undefined; private _publicOptions: ITerminalOptions; - constructor(options?: ITerminalOptions) { + constructor(options?: ITerminalOptions & ITerminalInitOnlyOptions) { this._core = new TerminalCore(options); this._addonManager = new AddonManager();