From 2febe19222b75fef2cbfb3ed5381aa7ca715107b Mon Sep 17 00:00:00 2001
From: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Date: Sat, 24 Sep 2022 14:42:57 -0700
Subject: [PATCH] Set renderer after screen element is attached to dom

---
 src/browser/Terminal.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts
index 728237b9..aae5cdef 100644
--- a/src/browser/Terminal.ts
+++ b/src/browser/Terminal.ts
@@ -517,11 +517,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
     this.register(this._renderService.onRenderedViewportChange(e => this._onRender.fire(e)));
     this.onResize(e => this._renderService!.resize(e.cols, e.rows));
 
-    this._onWillOpen.fire(this.element);
-    if (!this._renderService.hasRenderer()) {
-      this._renderService.setRenderer(this._createRenderer());
-    }
-
     this._compositionView = document.createElement('div');
     this._compositionView.classList.add('composition-view');
     this._compositionHelper = this._instantiationService.createInstance(CompositionHelper, this.textarea, this._compositionView);
@@ -530,6 +525,11 @@ export class Terminal extends CoreTerminal implements ITerminal {
     // Performance: Add viewport and helper elements from the fragment
     this.element.appendChild(fragment);
 
+    this._onWillOpen.fire(this.element);
+    if (!this._renderService.hasRenderer()) {
+      this._renderService.setRenderer(this._createRenderer());
+    }
+
     this._mouseService = this._instantiationService.createInstance(MouseService);
     this._instantiationService.setService(IMouseService, this._mouseService);