From 2b91bb83faa0d34cafaab908a943898bf8418d4d Mon Sep 17 00:00:00 2001 From: jeanp413 Date: Thu, 9 Jul 2020 20:35:01 -0500 Subject: [PATCH] :lipstick: --- src/browser/Clipboard.ts | 1 - src/browser/Terminal.ts | 15 +++++++-------- src/browser/input/CompositionHelper.ts | 1 - 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/browser/Clipboard.ts b/src/browser/Clipboard.ts index b845c421..b0b42022 100644 --- a/src/browser/Clipboard.ts +++ b/src/browser/Clipboard.ts @@ -70,7 +70,6 @@ export function moveTextAreaUnderMouseCursor(ev: MouseEvent, textarea: HTMLTextA const top = ev.clientY - pos.top - 10; // Bring textarea at the cursor position - textarea.style.position = 'absolute'; textarea.style.width = '20px'; textarea.style.height = '20px'; textarea.style.left = `${left}px`; diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts index beb823a9..bf94fd44 100644 --- a/src/browser/Terminal.ts +++ b/src/browser/Terminal.ts @@ -282,7 +282,7 @@ export class Terminal extends CoreTerminal implements ITerminal { } private _syncTextArea(): void { - if (!this.buffer.isCursorInViewport || this._compositionHelper!.isComposing) { + if (!this.textarea || !this.buffer.isCursorInViewport || this._compositionHelper!.isComposing) { return; } @@ -292,13 +292,12 @@ export class Terminal extends CoreTerminal implements ITerminal { // Sync the textarea to the exact position of the composition view so the IME knows where the // text is. - this.textarea!.style.position = 'absolute'; - this.textarea!.style.left = cursorLeft + 'px'; - this.textarea!.style.top = cursorTop + 'px'; - this.textarea!.style.width = this._charSizeService!.width + 'px'; - this.textarea!.style.height = cellHeight + 'px'; - this.textarea!.style.lineHeight = cellHeight + 'px'; - this.textarea!.style.zIndex = '-5'; + this.textarea.style.left = cursorLeft + 'px'; + this.textarea.style.top = cursorTop + 'px'; + this.textarea.style.width = this._charSizeService!.width + 'px'; + this.textarea.style.height = cellHeight + 'px'; + this.textarea.style.lineHeight = cellHeight + 'px'; + this.textarea.style.zIndex = '-5'; } /** diff --git a/src/browser/input/CompositionHelper.ts b/src/browser/input/CompositionHelper.ts index b56bbfe2..8d393e33 100644 --- a/src/browser/input/CompositionHelper.ts +++ b/src/browser/input/CompositionHelper.ts @@ -207,7 +207,6 @@ export class CompositionHelper { // Sync the textarea to the exact position of the composition view so the IME knows where the // text is. const compositionViewBounds = this._compositionView.getBoundingClientRect(); - this._textarea.style.position = 'absolute'; this._textarea.style.left = cursorLeft + 'px'; this._textarea.style.top = cursorTop + 'px'; this._textarea.style.width = compositionViewBounds.width + 'px';