diff --git a/src/TestUtils.test.ts b/src/TestUtils.test.ts index 86745fc7..842f30d0 100644 --- a/src/TestUtils.test.ts +++ b/src/TestUtils.test.ts @@ -394,7 +394,7 @@ export class MockRenderer implements IRenderer { onSelectionChanged(start: [number, number], end: [number, number]): void {} onCursorMove(): void {} onOptionsChanged(): void {} - onWindowResize(devicePixelRatio: number): void {} + onDevicePixelRatioChange(): void {} clear(): void {} renderRows(start: number, end: number): void {} registerCharacterJoiner(handler: CharacterJoinerHandler): number { return 0; } diff --git a/src/renderer/RenderCoordinator.ts b/src/renderer/RenderCoordinator.ts index 4d051640..d8895bc4 100644 --- a/src/renderer/RenderCoordinator.ts +++ b/src/renderer/RenderCoordinator.ts @@ -31,12 +31,12 @@ export class RenderCoordinator extends Disposable { this.register(this._renderDebouncer); this._screenDprMonitor = new ScreenDprMonitor(); - this._screenDprMonitor.setListener(() => this._renderer.onWindowResize(window.devicePixelRatio)); + this._screenDprMonitor.setListener(() => this._renderer.onDevicePixelRatioChange()); this.register(this._screenDprMonitor); // dprchange should handle this case, we need this as well for browsers that don't support the // matchMedia query. - this.register(addDisposableDomListener(window, 'resize', () => this._renderer.onWindowResize(window.devicePixelRatio))); + this.register(addDisposableDomListener(window, 'resize', () => this._renderer.onDevicePixelRatioChange())); } public refreshRows(start: number, end: number): void { diff --git a/src/renderer/Renderer.ts b/src/renderer/Renderer.ts index 754020fd..b941d314 100644 --- a/src/renderer/Renderer.ts +++ b/src/renderer/Renderer.ts @@ -76,11 +76,11 @@ export class Renderer extends Disposable implements IRenderer { } } - public onWindowResize(devicePixelRatio: number): void { + public onDevicePixelRatioChange(): void { // If the device pixel ratio changed, the char atlas needs to be regenerated // and the terminal needs to refreshed - if (this._devicePixelRatio !== devicePixelRatio) { - this._devicePixelRatio = devicePixelRatio; + if (this._devicePixelRatio !== window.devicePixelRatio) { + this._devicePixelRatio = window.devicePixelRatio; this.onResize(this._terminal.cols, this._terminal.rows); } } diff --git a/src/renderer/Types.ts b/src/renderer/Types.ts index d08360ef..a72546fb 100644 --- a/src/renderer/Types.ts +++ b/src/renderer/Types.ts @@ -29,7 +29,7 @@ export interface IRenderer extends IDisposable { dispose(): void; onThemeChange(colors: IColorSet): void; - onWindowResize(devicePixelRatio: number): void; + onDevicePixelRatioChange(): void; onResize(cols: number, rows: number): void; onCharSizeChanged(): void; onBlur(): void; diff --git a/src/renderer/dom/DomRenderer.ts b/src/renderer/dom/DomRenderer.ts index d1f877e5..1f3b11b8 100644 --- a/src/renderer/dom/DomRenderer.ts +++ b/src/renderer/dom/DomRenderer.ts @@ -213,7 +213,7 @@ export class DomRenderer extends Disposable implements IRenderer { this._themeStyleElement.innerHTML = styles; } - public onWindowResize(devicePixelRatio: number): void { + public onDevicePixelRatioChange(): void { this._updateDimensions(); }