diff --git a/src/AccessibilityManager.ts b/src/AccessibilityManager.ts index 1f44c132..4351a336 100644 --- a/src/AccessibilityManager.ts +++ b/src/AccessibilityManager.ts @@ -249,9 +249,11 @@ export class AccessibilityManager extends Disposable { const lineData = buffer.translateBufferLineToString(buffer.ydisp + i, true); const posInSet = (buffer.ydisp + i + 1).toString(); const element = this._rowElements[i]; - element.textContent = lineData.length === 0 ? Strings.blankLine : lineData; - element.setAttribute('aria-posinset', posInSet); - element.setAttribute('aria-setsize', setSize); + if (element) { + element.textContent = lineData.length === 0 ? Strings.blankLine : lineData; + element.setAttribute('aria-posinset', posInSet); + element.setAttribute('aria-setsize', setSize); + } } } diff --git a/src/Terminal.integration.ts b/src/Terminal.integration.ts index 5e12d2a3..fa4403f4 100644 --- a/src/Terminal.integration.ts +++ b/src/Terminal.integration.ts @@ -113,8 +113,8 @@ if (os.platform() !== 'win32') { 51, 52, 54, 55, 56, 57, 58, 59, 60, 61, 63, 68 ]; + // These are failing on macOS only if (os.platform() === 'darwin') { - // These are failing on macOS only skip.push(3, 7, 11, 67); } for (let i = 0; i < files.length; i++) { @@ -122,9 +122,9 @@ if (os.platform() !== 'win32') { continue; } ((filename: string) => { + const inFile = fs.readFileSync(filename, 'utf8'); it(filename.split('/').slice(-1)[0], done => { ptyReset(() => { - const inFile = fs.readFileSync(filename, 'utf8'); ptyWriteRead(inFile, fromPty => { // uncomment this to get log from terminal // console.log = function(){};