From 23076ba6ccc73c91872bb4bc4bfd29f64920ce3a Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Mon, 21 Mar 2022 16:20:51 -0700 Subject: [PATCH] Fix duplicate decorations getting created --- addons/xterm-addon-search/src/SearchAddon.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addons/xterm-addon-search/src/SearchAddon.ts b/addons/xterm-addon-search/src/SearchAddon.ts index d8266e02..c3fc3ecc 100644 --- a/addons/xterm-addon-search/src/SearchAddon.ts +++ b/addons/xterm-addon-search/src/SearchAddon.ts @@ -92,6 +92,7 @@ export class SearchAddon implements ITerminalAddon { private _disposeDecorations(): void { this._resultDecorations.forEach(decorations => { for (const d of decorations) { + console.log('dispose', d); d.dispose(); } }); @@ -189,9 +190,6 @@ export class SearchAddon implements ITerminalAddon { } } } - if (result && searchOptions?.decorations) { - this._createResultDecoration(result, searchOptions?.decorations); - } return result; } @@ -646,6 +644,7 @@ export class SearchAddon implements ITerminalAddon { if (!marker || !decorations?.matchColor) { return undefined; } + const findResultDecoration = terminal.registerDecoration( { marker, overviewRulerOptions: this._resultDecorations.get(marker.line) && !this._dataChanged ? undefined : { color: decorations.matchColor, position: 'center' }