From 49fdacba6a2e44f9f99ecd3deb0b2bdf0cdee271 Mon Sep 17 00:00:00 2001 From: jerch Date: Wed, 15 Mar 2023 15:41:44 +0100 Subject: [PATCH] fix BCE render bug in canvas renderer --- addons/xterm-addon-canvas/src/TextRenderLayer.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/addons/xterm-addon-canvas/src/TextRenderLayer.ts b/addons/xterm-addon-canvas/src/TextRenderLayer.ts index b429e8c2..4ee7c548 100644 --- a/addons/xterm-addon-canvas/src/TextRenderLayer.ts +++ b/addons/xterm-addon-canvas/src/TextRenderLayer.ts @@ -96,10 +96,11 @@ export class TextRenderLayer extends BaseRenderLayer { } // exit early for NULL and SP - const code = cell.getCode(); - if (code === 0 || code === 32) { - continue; - } + // NOTE: commented out due to #4120 (needs a more clever patch to keep things performant) + // const code = cell.getCode(); + // if (code === 0 || code === 32) { + // continue; + // } // Process any joined character ranges as needed. Because of how the // ranges are produced, we know that they are valid for the characters