From ad9818fb1a1f754fc584cf823364fba58187cba7 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 8 Feb 2022 20:29:20 -0600 Subject: [PATCH 1/3] Update typings/xterm.d.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- typings/xterm.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts index 5ba7dcf5..77fae602 100644 --- a/typings/xterm.d.ts +++ b/typings/xterm.d.ts @@ -936,7 +936,7 @@ declare module 'xterm' { * @param decorationOptions, which takes a marker and an optional anchor, * width, height, and x offset from the anchor. Returns the decoration or * undefined if the alt buffer is active or the marker has already been disposed of. - * @throws if the @param decorationOptions includes a negative x offset. + * @throws when options include a negative x offset. */ registerDecoration(decorationOptions: IDecorationOptions): IDecoration | undefined; From 53606820a7f11e8a3d536a44d7cc87aa875da581 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 8 Feb 2022 21:02:15 -0600 Subject: [PATCH 2/3] Update src/browser/services/DecorationService.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- src/browser/services/DecorationService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/services/DecorationService.ts b/src/browser/services/DecorationService.ts index cfe10045..992cd339 100644 --- a/src/browser/services/DecorationService.ts +++ b/src/browser/services/DecorationService.ts @@ -19,7 +19,7 @@ export interface IDecorationService extends IDisposable { export class DecorationService extends Disposable implements IDecorationService { - private _decorations: Decoration[] = []; + private readonly _decorations: Decoration[] = []; constructor( private readonly _screenElement: HTMLElement, From a9b496f06f48edaebd0d6b5b368e7b1914b1f849 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 8 Feb 2022 21:18:31 -0600 Subject: [PATCH 3/3] Update src/browser/services/DecorationService.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- src/browser/services/DecorationService.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/browser/services/DecorationService.ts b/src/browser/services/DecorationService.ts index 992cd339..cc059d21 100644 --- a/src/browser/services/DecorationService.ts +++ b/src/browser/services/DecorationService.ts @@ -61,9 +61,9 @@ export class DecorationService extends Disposable implements IDecorationService export const IDecorationService = createDecorator('DecorationService'); class Decoration extends Disposable implements IDecoration { private static _nextId = 1; - private _marker: IMarker; + private readonly _marker: IMarker; private _element: HTMLElement | undefined; - private _id: number = Decoration._nextId++; + private readonly _id: number = Decoration._nextId++; public isDisposed: boolean = false; public get id(): number { return this._id; }