From 2bd043b6642385507e67530cb746d79ab4ee011a Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Sat, 15 Jun 2019 14:42:04 -0700 Subject: [PATCH 1/3] Remove FLAGS constant Only WebGL uses this --- src/renderer/Constants.ts | 17 ----------------- 1 file changed, 17 deletions(-) delete mode 100644 src/renderer/Constants.ts diff --git a/src/renderer/Constants.ts b/src/renderer/Constants.ts deleted file mode 100644 index 36ce9b07..00000000 --- a/src/renderer/Constants.ts +++ /dev/null @@ -1,17 +0,0 @@ -/** - * Copyright (c) 2017 The xterm.js authors. All rights reserved. - * @license MIT - */ - -/** - * Flags used to render terminal text properly for the old CharData format - */ -export const enum FLAGS { - BOLD = 1, - UNDERLINE = 2, - BLINK = 4, - INVERSE = 8, - INVISIBLE = 16, - DIM = 32, - ITALIC = 64 -} From ed9000cb1d0f345843fa2b14aa9e047ecd52d6dd Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Sat, 15 Jun 2019 14:42:30 -0700 Subject: [PATCH 2/3] Clarify ITheme.selection color --- typings/xterm.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts index 042ca537..f435367d 100644 --- a/typings/xterm.d.ts +++ b/typings/xterm.d.ts @@ -191,7 +191,7 @@ declare module 'xterm' { cursor?: string, /** The accent color of the cursor (fg color for a block cursor) */ cursorAccent?: string, - /** The selection color (can be transparent) */ + /** The selection background color (can be transparent) */ selection?: string, /** ANSI black (eg. `\x1b[30m`) */ black?: string, From 29db1a2b2b39b7990053e6f93a8836cc5ba684df Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Sat, 15 Jun 2019 14:44:05 -0700 Subject: [PATCH 3/3] Refresh viewport after setting renderer and set correct end refresh row --- src/browser/services/RenderService.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/browser/services/RenderService.ts b/src/browser/services/RenderService.ts index 00f3a769..b41f1ebc 100644 --- a/src/browser/services/RenderService.ts +++ b/src/browser/services/RenderService.ts @@ -105,13 +105,14 @@ export class RenderService extends Disposable implements IRenderService { // TODO: RenderCoordinator should be the only one to dispose the renderer this._renderer.dispose(); this._renderer = renderer; + this.refreshRows(0, this._rowCount - 1); } private _fullRefresh(): void { if (this._isPaused) { this._needsFullRefresh = true; } else { - this.refreshRows(0, this._rowCount); + this.refreshRows(0, this._rowCount - 1); } } @@ -122,7 +123,7 @@ export class RenderService extends Disposable implements IRenderService { public onDevicePixelRatioChange(): void { this._renderer.onDevicePixelRatioChange(); - this.refreshRows(0, this._rowCount); + this.refreshRows(0, this._rowCount - 1); } public onResize(cols: number, rows: number): void {