From 7b874473d3c67499201a49caf16afafdd9d17296 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu, 17 Aug 2023 09:10:38 -0700 Subject: [PATCH] Remove unneeded comments, headless options --- src/browser/Terminal.ts | 14 -------------- src/headless/Terminal.ts | 16 ---------------- 2 files changed, 30 deletions(-) diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts index 71998bd5..b17f0dd8 100644 --- a/src/browser/Terminal.ts +++ b/src/browser/Terminal.ts @@ -74,8 +74,6 @@ export class Terminal extends CoreTerminal implements ITerminal { private _overviewRulerRenderer: OverviewRulerRenderer | undefined; - // private _visualBellTimer: number; - public browser: IBrowser = Browser as any; private _customKeyEventHandler: CustomKeyEventHandler | undefined; @@ -146,18 +144,6 @@ export class Terminal extends CoreTerminal implements ITerminal { private _onWillOpen = this.register(new EventEmitter()); public get onWillOpen(): IEvent { return this._onWillOpen.event; } - /** - * Creates a new `Terminal` object. - * - * @param options An object containing a set of options, the available options are: - * - `cursorBlink` (boolean): Whether the terminal cursor blinks - * - `cols` (number): The number of columns of the terminal (horizontal size) - * - `rows` (number): The number of rows of the terminal (vertical size) - * - * @public - * @class Xterm Xterm - * @alias module:xterm/src/xterm - */ constructor( options: Partial = {} ) { diff --git a/src/headless/Terminal.ts b/src/headless/Terminal.ts index 73bcbe13..18000c8f 100644 --- a/src/headless/Terminal.ts +++ b/src/headless/Terminal.ts @@ -25,13 +25,9 @@ import { DEFAULT_ATTR_DATA } from 'common/buffer/BufferLine'; import { IBuffer } from 'common/buffer/Types'; import { CoreTerminal } from 'common/CoreTerminal'; import { EventEmitter, forwardEvent } from 'common/EventEmitter'; -import { ITerminalOptions as IInitializedTerminalOptions } from 'common/services/Services'; import { IMarker, ITerminalOptions, ScrollSource } from 'common/Types'; export class Terminal extends CoreTerminal { - // TODO: We should remove options once components adopt optionsService - public get options(): Required { return this.optionsService.options; } - private readonly _onBell = this.register(new EventEmitter()); public readonly onBell = this._onBell.event; private readonly _onCursorMove = this.register(new EventEmitter()); @@ -43,18 +39,6 @@ export class Terminal extends CoreTerminal { private readonly _onA11yTabEmitter = this.register(new EventEmitter()); public readonly onA11yTab = this._onA11yTabEmitter.event; - /** - * Creates a new `Terminal` object. - * - * @param options An object containing a set of options, the available options are: - * - `cursorBlink` (boolean): Whether the terminal cursor blinks - * - `cols` (number): The number of columns of the terminal (horizontal size) - * - `rows` (number): The number of rows of the terminal (vertical size) - * - * @public - * @class Xterm Xterm - * @alias module:xterm/src/xterm - */ constructor( options: ITerminalOptions = {} ) {