From 1da492646cb2fa1920aa2b18a3b7e5d5fad0d548 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Tue, 22 Feb 2022 14:14:05 -0600 Subject: [PATCH] re-add dispose of marker --- src/browser/services/DecorationService.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/browser/services/DecorationService.ts b/src/browser/services/DecorationService.ts index de90649e..5cf7a106 100644 --- a/src/browser/services/DecorationService.ts +++ b/src/browser/services/DecorationService.ts @@ -145,6 +145,9 @@ export class Decoration extends Disposable implements IDecoration { if (this._element && this._container.contains(this._element)) { this._container.removeChild(this._element); } + if (!this.marker.isDisposed) { + this.marker.dispose(); + } this.isDisposed = true; // Emit before super.dispose such that dispose listeners get a change to react this._onDispose.fire();