From 1c5596de66de859c45a23cd213a49a56c1650966 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Sat, 19 Aug 2023 15:21:42 -0700 Subject: [PATCH] Split up Base64Decoder decoding tests Fixes #4696 --- addons/xterm-addon-image/src/base64.test.ts | 33 ++++++++++----------- src/common/input/TextDecoder.test.ts | 2 +- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/addons/xterm-addon-image/src/base64.test.ts b/addons/xterm-addon-image/src/base64.test.ts index 6b82893a..2d4e6d76 100644 --- a/addons/xterm-addon-image/src/base64.test.ts +++ b/addons/xterm-addon-image/src/base64.test.ts @@ -45,10 +45,9 @@ describe('Base64Decoder', () => { assert.deepEqual(dec.data8, inp); } }); - it('1+2 bytes', function() { - this.timeout(20000); - const dec = new Base64Decoder(0); - for (let a = 0; a < 256; ++a) { + for (let a = 0; a < 256; ++a) { + it(`1+2 bytes (${a})`, function() { + const dec = new Base64Decoder(0); for (let b = 0; b < 256; ++b) { dec.init(2); const inp = new Uint8Array([a, b]); @@ -57,12 +56,11 @@ describe('Base64Decoder', () => { assert.strictEqual(dec.end(), 0); assert.deepEqual(dec.data8, inp); } - } - }); - it('2+3 bytes', function() { - this.timeout(20000); - const dec = new Base64Decoder(0); - for (let a = 0; a < 256; ++a) { + }); + } + for (let a = 0; a < 256; ++a) { + it(`2+3 bytes (${a})`, function() { + const dec = new Base64Decoder(0); for (let b = 0; b < 256; ++b) { dec.init(3); const inp = new Uint8Array([0, a, b]); @@ -71,12 +69,11 @@ describe('Base64Decoder', () => { assert.strictEqual(dec.end(), 0); assert.deepEqual(dec.data8, inp); } - } - }); - it('3+4 bytes', function() { - this.timeout(20000); - const dec = new Base64Decoder(0); - for (let a = 0; a < 256; ++a) { + }); + } + for (let a = 0; a < 256; ++a) { + it(`3+4 bytes (${a})`, function() { + const dec = new Base64Decoder(0); for (let b = 0; b < 256; ++b) { dec.init(4); const inp = new Uint8Array([0, 0, a, b]); @@ -85,8 +82,8 @@ describe('Base64Decoder', () => { assert.strictEqual(dec.end(), 0); assert.deepEqual(dec.data8, inp); } - } - }); + }); + } it('padding', () => { const dec = new Base64Decoder(0); const d = fromBs('Hello, here comes the mouse'); diff --git a/src/common/input/TextDecoder.test.ts b/src/common/input/TextDecoder.test.ts index 20fd3508..abf9e47f 100644 --- a/src/common/input/TextDecoder.test.ts +++ b/src/common/input/TextDecoder.test.ts @@ -54,7 +54,7 @@ describe('text encodings', () => { assert.equal(utf32ToString(data), s); }); - describe.only('StringToUtf32 decoder', () => { + describe('StringToUtf32 decoder', () => { describe('full codepoint test', () => { for (let min = 0; min < 65535; min += BATCH_SIZE) { const max = Math.min(min + BATCH_SIZE, 65536);