From 1965daff504a2ec1ff8c32827e76e80d11b728e2 Mon Sep 17 00:00:00 2001
From: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Date: Thu, 24 Aug 2023 06:24:25 -0700
Subject: [PATCH] Warn on eslint rule @typescript-eslint/no-useless-constructor

---
 .eslintrc.json                                     | 1 +
 addons/xterm-addon-fit/src/FitAddon.ts             | 2 --
 addons/xterm-addon-serialize/src/SerializeAddon.ts | 2 --
 src/browser/Linkifier2.test.ts                     | 4 ----
 src/common/Lifecycle.ts                            | 3 ---
 src/common/public/AddonManager.ts                  | 3 ---
 6 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 7e8be09c..d206927e 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -127,6 +127,7 @@
       { "selector": "typeLike", "format": ["PascalCase"] },
       { "selector": "interface", "format": ["PascalCase"], "prefix": ["I"] }
     ],
+    "@typescript-eslint/no-useless-constructor": "warn",
     "@typescript-eslint/prefer-namespace-keyword": "warn",
     "@typescript-eslint/type-annotation-spacing": "warn",
     "@typescript-eslint/quotes": [
diff --git a/addons/xterm-addon-fit/src/FitAddon.ts b/addons/xterm-addon-fit/src/FitAddon.ts
index 6b3df6f0..f7245462 100644
--- a/addons/xterm-addon-fit/src/FitAddon.ts
+++ b/addons/xterm-addon-fit/src/FitAddon.ts
@@ -24,8 +24,6 @@ const MINIMUM_ROWS = 1;
 export class FitAddon implements ITerminalAddon {
   private _terminal: Terminal | undefined;
 
-  constructor() {}
-
   public activate(terminal: Terminal): void {
     this._terminal = terminal;
   }
diff --git a/addons/xterm-addon-serialize/src/SerializeAddon.ts b/addons/xterm-addon-serialize/src/SerializeAddon.ts
index ace31315..7a2db089 100644
--- a/addons/xterm-addon-serialize/src/SerializeAddon.ts
+++ b/addons/xterm-addon-serialize/src/SerializeAddon.ts
@@ -414,8 +414,6 @@ class StringSerializeHandler extends BaseSerializeHandler {
 export class SerializeAddon implements ITerminalAddon {
   private _terminal: Terminal | undefined;
 
-  constructor() { }
-
   public activate(terminal: Terminal): void {
     this._terminal = terminal;
   }
diff --git a/src/browser/Linkifier2.test.ts b/src/browser/Linkifier2.test.ts
index c1a0cf6c..0af74c28 100644
--- a/src/browser/Linkifier2.test.ts
+++ b/src/browser/Linkifier2.test.ts
@@ -10,10 +10,6 @@ import { MockBufferService } from 'common/TestUtils.test';
 import { ILink } from 'browser/Types';
 
 class TestLinkifier2 extends Linkifier2 {
-  constructor(bufferService: IBufferService) {
-    super(bufferService);
-  }
-
   public set currentLink(link: any) {
     this._currentLink = link;
   }
diff --git a/src/common/Lifecycle.ts b/src/common/Lifecycle.ts
index 659403de..6e5ef27d 100644
--- a/src/common/Lifecycle.ts
+++ b/src/common/Lifecycle.ts
@@ -13,9 +13,6 @@ export abstract class Disposable implements IDisposable {
   protected _disposables: IDisposable[] = [];
   protected _isDisposed: boolean = false;
 
-  constructor() {
-  }
-
   /**
    * Disposes the object, triggering the `dispose` method on all registered IDisposables.
    */
diff --git a/src/common/public/AddonManager.ts b/src/common/public/AddonManager.ts
index 06c78121..af04a269 100644
--- a/src/common/public/AddonManager.ts
+++ b/src/common/public/AddonManager.ts
@@ -14,9 +14,6 @@ export interface ILoadedAddon {
 export class AddonManager implements IDisposable {
   protected _addons: ILoadedAddon[] = [];
 
-  constructor() {
-  }
-
   public dispose(): void {
     for (let i = this._addons.length - 1; i >= 0; i--) {
       this._addons[i].instance.dispose();