diff --git a/src/xterm.js b/src/xterm.js index 4d42c5d4..454188b7 100644 --- a/src/xterm.js +++ b/src/xterm.js @@ -1352,12 +1352,6 @@ Terminal.prototype.write = function(data) { this.refreshStart = this.y; this.refreshEnd = this.y; - // if (this.ybase !== this.ydisp) { - // this.ydisp = this.ybase; - // this.emit('scroll', this.ydisp); - // this.maxRange(); - // } - // apply leftover surrogate high from last write if (this.surrogate_high) { data = this.surrogate_high + data; @@ -2423,6 +2417,11 @@ Terminal.prototype.attachCustomKeydownHandler = function(customKeydownHandler) { * @param {KeyboardEvent} ev The keydown event to be handled. */ Terminal.prototype.keyDown = function(ev) { + // Scroll down to prompt, whenever the user presses a key. + if (this.ybase !== this.ydisp) { + this.scrollToBottom(); + } + if (this.customKeydownHandler && this.customKeydownHandler(ev) === false) { return false; } @@ -2974,7 +2973,7 @@ Terminal.prototype.updateRange = function(y) { }; /** - * Set the range of refreshing to the maximyum value + * Set the range of refreshing to the maximum value */ Terminal.prototype.maxRange = function() { this.refreshStart = 0; diff --git a/test/test.js b/test/test.js index eb34a44e..8cdf2db6 100644 --- a/test/test.js +++ b/test/test.js @@ -181,6 +181,25 @@ describe('xterm.js', function() { assert.equal(xterm.ydisp, startYDisp); }); }); + + describe('keyDown', function () { + it('should scroll down, when a key is pressed and terminal is scrolled up', function () { + var terminal = new Terminal(); + + // Do not process the keyDown event, to avoid side-effects + terminal.attachCustomKeydownHandler(function () { + return false; + }); + + terminal.ydisp = 0; + terminal.ybase = 40; + + terminal.keyDown(); + + // Ensure that now the terminal is scrolled to bottom + assert.equal(terminal.ydisp, terminal.ybase); + }); + }); }); describe('evaluateKeyEscapeSequence', function() {