From 0ccf3beec7cfddc1fdce5a6ca50ffd64f733e39c Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Sun, 24 Jul 2022 08:03:27 -0700 Subject: [PATCH] Retain hue when flipping luminance Fixes #3845 --- src/common/Color.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/Color.ts b/src/common/Color.ts index e5c7e3eb..f62dd6cb 100644 --- a/src/common/Color.ts +++ b/src/common/Color.ts @@ -195,7 +195,7 @@ export namespace rgba { const resultA = reduceLuminance(bgRgba, fgRgba, ratio); const resultARatio = contrastRatio(bgL, rgb.relativeLuminance(resultA >> 8)); if (resultARatio < ratio) { - const resultB = increaseLuminance(bgRgba, bgRgba, ratio); + const resultB = increaseLuminance(bgRgba, fgRgba, ratio); const resultBRatio = contrastRatio(bgL, rgb.relativeLuminance(resultB >> 8)); return resultARatio > resultBRatio ? resultA : resultB; } @@ -204,7 +204,7 @@ export namespace rgba { const resultA = increaseLuminance(bgRgba, fgRgba, ratio); const resultARatio = contrastRatio(bgL, rgb.relativeLuminance(resultA >> 8)); if (resultARatio < ratio) { - const resultB = reduceLuminance(bgRgba, bgRgba, ratio); + const resultB = reduceLuminance(bgRgba, fgRgba, ratio); const resultBRatio = contrastRatio(bgL, rgb.relativeLuminance(resultB >> 8)); return resultARatio > resultBRatio ? resultA : resultB; }