From 086ca58eceff7393f6655439f0f479b3ab5ee991 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 22 Dec 2021 09:10:12 -0800 Subject: [PATCH] Comment tweaks --- src/browser/Color.ts | 2 -- src/common/input/XParseColor.ts | 5 ++++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/browser/Color.ts b/src/browser/Color.ts index a4e415af..32e311db 100644 --- a/src/browser/Color.ts +++ b/src/browser/Color.ts @@ -6,8 +6,6 @@ import { IColor } from 'browser/Types'; import { IColorRGB } from 'common/Types'; -// FIXME: Move Color.ts lib to common? - /** * Helper functions where the source type is "channels" (individual color channels as numbers). */ diff --git a/src/common/input/XParseColor.ts b/src/common/input/XParseColor.ts index 922bf8a9..8c023a38 100644 --- a/src/common/input/XParseColor.ts +++ b/src/common/input/XParseColor.ts @@ -49,7 +49,10 @@ export function parseColor(data: string): [number, number, number] | undefined { return result; } } - // FIXME: Once #3530 is resolved, implement named colors. + + // Named colors are currently not supported due to the large addition to the xterm.js bundle size + // they would add. In order to support named colors, we would need some way of optionally loading + // additional payloads so startup/download time is not bloated (see #3530). } // pad hex output to requested bit width