From 024404f5488d1ca9d75f962324f4c62af30638f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rg=20Breitbart?= <jerch@rockborn.de>
Date: Sat, 1 Sep 2018 00:18:52 +0200
Subject: [PATCH] make cols mandatory in BufferLine ctor

---
 src/BufferLine.test.ts                       | 2 +-
 src/BufferLine.ts                            | 4 ++--
 src/Types.ts                                 | 3 ---
 src/renderer/CharacterJoinerRegistry.test.ts | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/BufferLine.test.ts b/src/BufferLine.test.ts
index 8b0bcbb3..9d6ba036 100644
--- a/src/BufferLine.test.ts
+++ b/src/BufferLine.test.ts
@@ -20,7 +20,7 @@ class TestBufferLine extends BufferLine {
 
 describe('BufferLine', function(): void {
   it('ctor', function(): void {
-    let line: IBufferLine = new TestBufferLine();
+    let line: IBufferLine = new TestBufferLine(0);
     chai.expect(line.length).equals(0);
     chai.expect(line.isWrapped).equals(false);
     line = new TestBufferLine(10);
diff --git a/src/BufferLine.ts b/src/BufferLine.ts
index 891aa177..de36a968 100644
--- a/src/BufferLine.ts
+++ b/src/BufferLine.ts
@@ -17,7 +17,7 @@ export class BufferLineOld implements IBufferLine {
   public isWrapped = false;
   public length: number;
 
-  constructor(cols?: number, ch?: CharData, isWrapped?: boolean) {
+  constructor(cols: number, ch?: CharData, isWrapped?: boolean) {
     this._data = [];
     this.length = this._data.length;
     if (cols) {
@@ -111,7 +111,7 @@ export class BufferLine implements IBufferLine {
   protected _combined: {[index: number]: string} = {};
   public length: number;
 
-  constructor(cols?: number, ch?: CharData, public isWrapped: boolean = false) {
+  constructor(cols: number, ch?: CharData, public isWrapped: boolean = false) {
     this.length = cols || 0;
     if (cols) {
       if (!ch) {
diff --git a/src/Types.ts b/src/Types.ts
index 90e1a531..3a83ee89 100644
--- a/src/Types.ts
+++ b/src/Types.ts
@@ -516,9 +516,6 @@ export interface IBufferLine {
   isWrapped: boolean;
   get(index: number): CharData;
   set(index: number, value: CharData): void;
-  // pop(): CharData | undefined;
-  // push(data: CharData): void;
-  // splice(start: number, deleteCount: number, ...items: CharData[]): CharData[];
   insertCells(pos: number, n: number, ch: CharData): void;
   deleteCells(pos: number, n: number, fill: CharData): void;
   replaceCells(start: number, end: number, fill: CharData): void;
diff --git a/src/renderer/CharacterJoinerRegistry.test.ts b/src/renderer/CharacterJoinerRegistry.test.ts
index e1981698..383d2a7f 100644
--- a/src/renderer/CharacterJoinerRegistry.test.ts
+++ b/src/renderer/CharacterJoinerRegistry.test.ts
@@ -21,7 +21,7 @@ describe('CharacterJoinerRegistry', () => {
     lines.set(2, lineData([['a -> b -', 0xFFFFFFFF], ['> c -> d', 0]]));
 
     lines.set(3, lineData([['no joined ranges']]));
-    lines.set(4, new BufferLine());
+    lines.set(4, new BufferLine(0));
     lines.set(5, lineData([['a', 0x11111111], [' -> b -> c -> '], ['d', 0x22222222]]));
     const line6 = lineData([['wi']]);
     line6.resize(line6.length + 1, [0, '￥', 2, '￥'.charCodeAt(0)]);