From fbe7d4de6bc9a37950fe009b0b42133c804ec542 Mon Sep 17 00:00:00 2001 From: Travis McLane Date: Wed, 12 Apr 2023 06:34:31 -0500 Subject: [PATCH] Bugfix/remove miniaturize (#2579) * remove duplicate 'minimize' from interface already covered by 'minimise' * [darwin] remove windowMiniaturize duplicates the logic in windowMinimise --------- Co-authored-by: Lea Anthony --- v3/pkg/application/webview_window.go | 3 +-- v3/pkg/application/webview_window_darwin.go | 12 ------------ 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/v3/pkg/application/webview_window.go b/v3/pkg/application/webview_window.go index 76981c8a..e9899fe8 100644 --- a/v3/pkg/application/webview_window.go +++ b/v3/pkg/application/webview_window.go @@ -39,7 +39,6 @@ type ( setZoom(zoom float64) close() zoom() - minimize() setHTML(html string) setPosition(x int, y int) on(eventID uint) @@ -485,7 +484,7 @@ func (w *WebviewWindow) Minimize() { if w.impl == nil { return } - w.impl.minimize() + w.impl.minimise() } func (w *WebviewWindow) Zoom() { diff --git a/v3/pkg/application/webview_window_darwin.go b/v3/pkg/application/webview_window_darwin.go index 3f1f1a7b..c8728f2e 100644 --- a/v3/pkg/application/webview_window_darwin.go +++ b/v3/pkg/application/webview_window_darwin.go @@ -659,14 +659,6 @@ static void windowZoom(void *window) { }); } -// miniaturize -static void windowMiniaturize(void *window) { - dispatch_async(dispatch_get_main_queue(), ^{ - // miniaturize window - [(WebviewWindow*)window miniaturize:nil]; - }); -} - // webviewRenderHTML renders the given HTML static void windowRenderHTML(void *window, const char *html) { dispatch_async(dispatch_get_main_queue(), ^{ @@ -891,10 +883,6 @@ func (w *macosWebviewWindow) zoom() { C.windowZoom(w.nsWindow) } -func (w *macosWebviewWindow) minimize() { - C.windowMiniaturize(w.nsWindow) -} - func (w *macosWebviewWindow) windowZoom() { C.windowZoom(w.nsWindow) }