From 1e4af8991bdbb147c5e23bdc990d0308dfcfc78f Mon Sep 17 00:00:00 2001 From: Albert Sun Date: Sat, 22 Jan 2022 00:40:55 -0500 Subject: [PATCH 1/3] added export --- v2/internal/binding/generate.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2/internal/binding/generate.go b/v2/internal/binding/generate.go index 57635325..84618045 100644 --- a/v2/internal/binding/generate.go +++ b/v2/internal/binding/generate.go @@ -129,7 +129,7 @@ func (b *Bindings) GenerateBackendTS(targetfile string) error { store := b.db.store var output bytes.Buffer - output.WriteString("interface go {\n") + output.WriteString("export interface go {\n") var sortedPackageNames slicer.StringSlicer for packageName := range store { From 4118f348f5767dd9572a16862c764cc0e1671245 Mon Sep 17 00:00:00 2001 From: Albert Sun Date: Sat, 22 Jan 2022 00:59:26 -0500 Subject: [PATCH 2/3] fixed generate test --- v2/internal/binding/generate_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2/internal/binding/generate_test.go b/v2/internal/binding/generate_test.go index e2751ceb..2f6b8739 100644 --- a/v2/internal/binding/generate_test.go +++ b/v2/internal/binding/generate_test.go @@ -64,12 +64,12 @@ func Test_goTypeToJSDocType(t *testing.T) { { name: "[]int", input: "[]int", - want: "Array.", + want: "Array", }, { name: "[]bool", input: "[]bool", - want: "Array.", + want: "Array", }, { name: "anything else", From f5c3907fac3fd77d03fbe6977932f3311f8874fb Mon Sep 17 00:00:00 2001 From: Albert Sun Date: Sat, 22 Jan 2022 10:23:02 -0500 Subject: [PATCH 3/3] added interface{} test case and fixed --- v2/internal/binding/generate.go | 2 ++ v2/internal/binding/generate_test.go | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/v2/internal/binding/generate.go b/v2/internal/binding/generate.go index 84618045..8ae897bb 100644 --- a/v2/internal/binding/generate.go +++ b/v2/internal/binding/generate.go @@ -201,6 +201,8 @@ declare global { func goTypeToJSDocType(input string) string { switch true { + case input == "interface{}": + return "any" case input == "string": return "string" case input == "error": diff --git a/v2/internal/binding/generate_test.go b/v2/internal/binding/generate_test.go index 2f6b8739..10e66803 100644 --- a/v2/internal/binding/generate_test.go +++ b/v2/internal/binding/generate_test.go @@ -56,6 +56,11 @@ func Test_goTypeToJSDocType(t *testing.T) { input: "bool", want: "boolean", }, + { + name: "interface{}", + input: "interface{}", + want: "any", + }, { name: "[]byte", input: "[]byte",