From 781a0df72e9e0f490817042dd84e1098afc7da49 Mon Sep 17 00:00:00 2001 From: Lea Anthony Date: Wed, 27 Apr 2022 19:09:55 +1000 Subject: [PATCH] Fix for TS/JS generation on methods with no returns (#1356) --- v2/internal/binding/generate.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/v2/internal/binding/generate.go b/v2/internal/binding/generate.go index a509588e..c1912f3b 100644 --- a/v2/internal/binding/generate.go +++ b/v2/internal/binding/generate.go @@ -44,7 +44,11 @@ func (b *Bindings) GenerateGoBindings(baseDir string) error { argsString := args.Join(", ") jsoutput.WriteString(fmt.Sprintf("\nexport function %s(%s) {", methodName, argsString)) jsoutput.WriteString("\n") - jsoutput.WriteString(fmt.Sprintf(" return window['go']['%s']['%s']['%s'](%s);", packageName, structName, methodName, argsString)) + if methodDetails.OutputCount() == 0 { + jsoutput.WriteString(fmt.Sprintf(" window['go']['%s']['%s']['%s'](%s);", packageName, structName, methodName, argsString)) + } else { + jsoutput.WriteString(fmt.Sprintf(" return window['go']['%s']['%s']['%s'](%s);", packageName, structName, methodName, argsString)) + } jsoutput.WriteString("\n") jsoutput.WriteString(fmt.Sprintf("}")) jsoutput.WriteString("\n") @@ -68,7 +72,7 @@ func (b *Bindings) GenerateGoBindings(baseDir string) error { } returnType += ">" } else { - returnType = "Promise" + returnType = "void" } tsBody.WriteString(returnType + ";\n") }