From 8fc1d03a5fc88bb94545ba705dc234d9e3ba59cb Mon Sep 17 00:00:00 2001 From: Chapman Pendery <35637443+cpendery@users.noreply.github.com> Date: Fri, 1 Mar 2024 14:28:24 -0500 Subject: [PATCH] fix: readline detection for pwsh (#177) Signed-off-by: Chapman Pendery --- src/isterm/commandManager.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/isterm/commandManager.ts b/src/isterm/commandManager.ts index 4a3efbb..b48d8f5 100644 --- a/src/isterm/commandManager.ts +++ b/src/isterm/commandManager.ts @@ -151,11 +151,14 @@ export class CommandManager { private _isSuggestion(cell: IBufferCell | undefined): boolean { const color = cell?.getFgColor(); - const dullColor = color == 8 || (color ?? 0) > 235; + const dim = (cell?.isDim() ?? 0) > 0; + const italic = (cell?.isItalic() ?? 0) > 0; + const dullColor = color == 8 || color == 7 || (color ?? 0) > 235 || (color == 15 && dim); + const dullItalic = (color ?? 0) > 235 || (dullColor && italic); if (this.#shell == Shell.Powershell) { return false; } else if (this.#shell == Shell.Pwsh) { - return (color ?? 0) > 235; + return dullItalic; } return dullColor; }