From c5940309bc3db65fc39f42ace0878fb714ad7a90 Mon Sep 17 00:00:00 2001
From: Roland Walker <walker@pobox.com>
Date: Thu, 22 May 2014 12:48:39 -0400
Subject: [PATCH] move multiword value into array + quote it

---
 developer/bin/project_stats | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/developer/bin/project_stats b/developer/bin/project_stats
index b63bf2cbc3..61af8ffaea 100755
--- a/developer/bin/project_stats
+++ b/developer/bin/project_stats
@@ -87,20 +87,20 @@ print_contributor_stats () {
     printf "Contributors\n"
     printf "====================\n"
 
-    local git_log_cmd="git log --no-merges --format='%ae' "${start_object}".."${end_object}""
+    local -a git_log_cmd=("git" "log" "--no-merges" "--format='%ae'" "${start_object}..${end_object}")
     printf "Unique contributors"
     if ! [[ "$start_object" = "$initial_commit" ]]; then
         printf " since %s" "${start_object#v}"
     fi
     printf "\n"
-    cask_authors="$($git_log_cmd -- "${cask_paths[@]}" | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l)"
+    cask_authors="$("${git_log_cmd[@]}" -- "${cask_paths[@]}" | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l)"
     printf "  Casks\t%s\n" "$cask_authors"
     printf "  code\t"
-    $git_log_cmd -- "${code_paths[@]}" | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l
+    "${git_log_cmd[@]}" -- "${code_paths[@]}" | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l
     printf "  docs\t"
-    $git_log_cmd -- "${doc_paths[@]}"  | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l
+    "${git_log_cmd[@]}" -- "${doc_paths[@]}"  | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l
     printf "  any\t"
-    $git_log_cmd -- .                  | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l
+    "${git_log_cmd[@]}" -- .                  | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l
     if ! [[ "$start_object" = "$initial_commit" ]]; then
         local alltime_contribs="$(git log --no-merges --format='%ae' "${initial_commit}".."${end_object}" -- . | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l)"
         local prior_contribs="$(git log --no-merges --format='%ae' "${initial_commit}".."${start_object}" -- . | /usr/bin/sort | /usr/bin/uniq | /usr/bin/wc -l)"
@@ -121,20 +121,20 @@ print_commit_stats () {
     printf "Commits\n"
     printf "====================\n"
 
-    local git_log_cmd="git log --no-merges --format='%ae' "${start_object}".."${end_object}""
+    local -a git_log_cmd=("git" "log" "--no-merges" "--format='%ae'" "${start_object}..${end_object}")
     printf "Commit count"
     if ! [[ "$start_object" = "$initial_commit" ]]; then
         printf " since %s" "${start_object#v}"
     fi
     printf "\n"
     printf "  Casks\t"
-    $git_log_cmd -- "${cask_paths[@]}" | /usr/bin/wc -l
+    "${git_log_cmd[@]}" -- "${cask_paths[@]}" | /usr/bin/wc -l
     printf "  code\t"
-    $git_log_cmd -- "${code_paths[@]}" | /usr/bin/wc -l
+    "${git_log_cmd[@]}" -- "${code_paths[@]}" | /usr/bin/wc -l
     printf "  docs\t"
-    $git_log_cmd -- "${doc_paths[@]}"  | /usr/bin/wc -l
+    "${git_log_cmd[@]}" -- "${doc_paths[@]}"  | /usr/bin/wc -l
     printf "  any\t"
-    $git_log_cmd -- .                  | /usr/bin/wc -l
+    "${git_log_cmd[@]}" -- .                  | /usr/bin/wc -l
     if ! [[ "$start_object" = "$initial_commit" ]]; then
         printf "\nAll-time commits\t"
         git log --no-merges --format='%ae' "${initial_commit}".."${end_object}" -- . | /usr/bin/wc -l
@@ -150,13 +150,13 @@ print_doc_stats () {
     printf "Docs\n"
     printf "====================\n"
 
-    local git_log_cmd="git log --no-merges --format='%ae' "${start_object}".."${end_object}""
+    local -a git_log_cmd=("git" "log" "--no-merges" "--format='%ae'" "${start_object}..${end_object}")
     printf "Doc contributors"
     if ! [[ "$start_object" = "$initial_commit" ]]; then
         printf " since %s" "${start_object#v}"
     fi
     printf "\n  "
-    $git_log_cmd -- "${doc_paths[@]}" | /usr/bin/sort | /usr/bin/uniq | \
+    "${git_log_cmd[@]}" -- "${doc_paths[@]}" | /usr/bin/sort | /usr/bin/uniq | \
       /usr/bin/egrep -v $'^\'(paul\\.t\\.hinze@gmail\\.com|fanquake@users\\.noreply\\.github\\.com|fanquake@gmail\\.com|kevin@suttle\\.io|leoj3n@gmail\\.com|nano@fdp\\.io|nanoid\\.xd@gmail\\.com|me@passcod\\.name|walker@pobox\\.com|info@vitorgalvao\\.com|calebcenter@live\\.com|ndr@qef\\.io)\'$' | \
       "$xargs" | /usr/bin/perl -pe 's{ }{, }g'           # '
     printf "\n"