From 0d60d8f73d9a3cb9bff09795764197c8750fead3 Mon Sep 17 00:00:00 2001 From: Josh Hagins Date: Wed, 12 Oct 2016 05:35:42 -0400 Subject: [PATCH] Rename generate_issue_template_urls and take only one arg --- ...mplate_urls => generate_issue_template_url} | 18 +++++++----------- developer/bin/update_issue_template_urls | 6 +++--- 2 files changed, 10 insertions(+), 14 deletions(-) rename developer/bin/{generate_issue_template_urls => generate_issue_template_url} (66%) diff --git a/developer/bin/generate_issue_template_urls b/developer/bin/generate_issue_template_url similarity index 66% rename from developer/bin/generate_issue_template_urls rename to developer/bin/generate_issue_template_url index 916d849875..1270655116 100755 --- a/developer/bin/generate_issue_template_urls +++ b/developer/bin/generate_issue_template_url @@ -1,6 +1,6 @@ #!/usr/bin/env ruby # -# generate_issue_template_urls +# generate_issue_template_url # ### @@ -20,11 +20,8 @@ BASE_URL = "https://github.com/caskroom/homebrew-cask/issues/new".freeze ### def main(args) - args.each do |file| - File.read(file).scan(%r{(.*?)\n(.*)}m) do |title, body| - puts generate_url(title, body) - end - end + title, body = File.read(args[0]).match(%r{(.*?)\n(.*)}m).captures + print generate_url(title, body) end def generate_url(title, body) @@ -46,11 +43,10 @@ end ### usage = <<-EOS -Usage: generate_issue_template_urls ... +Usage: generate_issue_template_url -Given one or more GitHub issue template files, generate encoded URLs for each -and print, separated by newlines. The first line of a template file should be -the issue title. +Print an encoded URL for the given GitHub issue template. The first line of +a template file should be the issue title. With -debug, print out the encoded title and body individually as well. @@ -66,7 +62,7 @@ if ARGV.first =~ %r{^-+debug?$}i ARGV.shift end -if ARGV.empty? +if ARGV.size != 1 puts usage exit 1 end diff --git a/developer/bin/update_issue_template_urls b/developer/bin/update_issue_template_urls index 8e61ff69ec..63448b02fb 100755 --- a/developer/bin/update_issue_template_urls +++ b/developer/bin/update_issue_template_urls @@ -17,8 +17,8 @@ shopt -s nocasematch # case-insensitive regular expressions script_subdir='developer/bin' template_subdir='doc/issue_templates' -generate_url_script='generate_issue_template_urls' -files_to_update=('README.md') +generate_url_script='generate_issue_template_url' +files_to_update=(README.md doc/readme.md doc/reporting_bugs/*) ### ### functions @@ -77,7 +77,7 @@ update_template_url () { local escaped_template_url="${template_url/&/\\&}" /usr/bin/sed -i '' \ - -e "s|^\\(\\[${template_name}_template\\]: \\).*$|\\1${escaped_template_url}|g" \ + -e "s|^\\(\\[${template_name}\\]: \\).*$|\\1${escaped_template_url}|g" \ -- "${files_to_update[@]}" }