From 7df91de2e57a05bc7d81d7e4ff9382cfbac7ad23 Mon Sep 17 00:00:00 2001 From: Evan Simkowitz Date: Wed, 21 Aug 2024 15:23:15 -0700 Subject: [PATCH] use unauthorized instead of internalservererror for failed authkey validation --- pkg/web/web.go | 3 +-- pkg/web/ws.go | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/web/web.go b/pkg/web/web.go index eccd1893..406122e6 100644 --- a/pkg/web/web.go +++ b/pkg/web/web.go @@ -400,9 +400,8 @@ func WebFnWrap(opts WebFnOpts, fn WebFnType) WebFnType { w.Header().Set("Access-Control-Expose-Headers", "X-ZoneFileInfo") err := authkey.ValidateIncomingRequest(r) if err != nil { - w.WriteHeader(http.StatusInternalServerError) + w.WriteHeader(http.StatusUnauthorized) w.Write([]byte(fmt.Sprintf("error validating authkey: %v", err))) - log.Printf("error validating request: %v", err) return } fn(w, r) diff --git a/pkg/web/ws.go b/pkg/web/ws.go index 267c9f27..e75d290b 100644 --- a/pkg/web/ws.go +++ b/pkg/web/ws.go @@ -248,9 +248,8 @@ func HandleWsInternal(w http.ResponseWriter, r *http.Request) error { err := authkey.ValidateIncomingRequest(r) if err != nil { - w.WriteHeader(http.StatusInternalServerError) + w.WriteHeader(http.StatusUnauthorized) w.Write([]byte(fmt.Sprintf("error validating authkey: %v", err))) - log.Printf("error validating request: %v", err) return err } conn, err := WebSocketUpgrader.Upgrade(w, r, nil)