From 7a5afccab3117efe13a8652cd1232d320cb88e12 Mon Sep 17 00:00:00 2001 From: sawka Date: Fri, 9 Feb 2024 20:05:00 -0300 Subject: [PATCH] do not unset ZDOTDIR otherwise interactive configs will be unnecessarily re-read (causing big performance problem for zsh command initialization) --- waveshell/pkg/shellapi/zshapi.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/waveshell/pkg/shellapi/zshapi.go b/waveshell/pkg/shellapi/zshapi.go index 2b4cdf84..ac8000cb 100644 --- a/waveshell/pkg/shellapi/zshapi.go +++ b/waveshell/pkg/shellapi/zshapi.go @@ -257,10 +257,7 @@ func (z zshShellApi) MakeRcFileStr(pk *packet.RunPacketType) string { } rcBuf.WriteString("\n") } - if shellenv.FindVarDecl(varDecls, "ZDOTDIR") == nil { - rcBuf.WriteString("unset ZDOTDIR\n") - rcBuf.WriteString("\n") - } + // do NOT unset ZDOTDIR, otherwise initialization will start to read initialization files from ~/ again for _, varName := range ZshUnsetVars { rcBuf.WriteString("unset " + shellescape.Quote(varName) + "\n") }