From 781ebe8154cd3a5304a0be62e2f2107bc486e857 Mon Sep 17 00:00:00 2001
From: sawka <mike.sawka@gmail.com>
Date: Sat, 16 Dec 2023 11:36:38 -0800
Subject: [PATCH] add checking for latestversion (avoid potential error in
 semver.compareLoose)

---
 src/app/sidebar/sidebar.tsx | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/app/sidebar/sidebar.tsx b/src/app/sidebar/sidebar.tsx
index adf2953e..57dcd9bd 100644
--- a/src/app/sidebar/sidebar.tsx
+++ b/src/app/sidebar/sidebar.tsx
@@ -197,6 +197,10 @@ class MainSideBar extends React.Component<{}, {}> {
         let isCollapsed = this.collapsed.get();
         let mainView = GlobalModel.activeMainView.get();
         let clientData = GlobalModel.clientData.get();
+        let needsUpdate = false;
+        if (!clientData?.clientopts.noreleasecheck && !isBlank(clientData?.releaseinfo?.latestversion)) {
+            needsUpdate = compareLoose(VERSION, clientData.releaseinfo.latestversion) < 0;
+        }
         return (
             <div className={cn("main-sidebar", { collapsed: isCollapsed }, { "is-dev": GlobalModel.isDev })}>
                 <div className="title-bar-drag" />
@@ -244,7 +248,7 @@ class MainSideBar extends React.Component<{}, {}> {
                     </div>
                     <div className="middle hideScrollbarUntillHover">{this.getSessions()}</div>
                     <div className="bottom">
-                        <If condition = {!clientData?.clientopts.noreleasecheck && clientData?.releaseinfo && compareLoose(VERSION, clientData.releaseinfo.latestversion) < 0} >
+                        <If condition={needsUpdate}>
                             <div
                                 className="item hoverEffect unselectable updateBanner"
                                 onClick={() => openLink("https://www.waveterm.dev/download")}