From 67544c9a0ff2de7ab3b6bbe73171cf386503a1ed Mon Sep 17 00:00:00 2001 From: Evan Simkowitz Date: Thu, 2 May 2024 17:53:47 -0700 Subject: [PATCH] Fix Build Helper for Yarn Modern (#646) I am removing the Yarn cache from our Build Helper. The actions/node-setup cache option is not compatible with Yarn Modern. With Yarn Modern, the `yarn install` command that sets up our project-specific yarn config will also install all the module dependencies, meaning we don't need a separate call to resolve these. Altogether, even without the cache, it only takes 21s for Yarn Modern to install and resolve dependencies. --- .github/workflows/build-helper.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/build-helper.yml b/.github/workflows/build-helper.yml index e0661bb8..931b8e0a 100644 --- a/.github/workflows/build-helper.yml +++ b/.github/workflows/build-helper.yml @@ -45,7 +45,6 @@ jobs: - uses: actions/setup-node@v4 with: node-version: ${{env.NODE_VERSION}} - cache: "yarn" - name: Install yarn run: | corepack enable @@ -55,8 +54,6 @@ jobs: run: | VERSION=$(node -e 'console.log(require("./version.js"))') echo "WAVETERM_VERSION=${VERSION}" >> "$GITHUB_OUTPUT" - - name: Install Yarn Dependencies - run: yarn --frozen-lockfile - name: Build ${{ matrix.platform }}/${{ matrix.arch }} run: scripthaus run ${{ matrix.scripthaus }} env: