From 4429607eb5970867f67af1d704881f882213a691 Mon Sep 17 00:00:00 2001
From: sawka <mike.sawka@gmail.com>
Date: Mon, 6 Feb 2023 12:08:07 -0800
Subject: [PATCH] refactor the data buffer functionality

---
 src/imagerenderer.ts | 50 +++++++-------------------------------
 src/main.tsx         |  2 +-
 src/ptydata.ts       | 58 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 68 insertions(+), 42 deletions(-)
 create mode 100644 src/ptydata.ts

diff --git a/src/imagerenderer.ts b/src/imagerenderer.ts
index 990a040d..c9e6b6f3 100644
--- a/src/imagerenderer.ts
+++ b/src/imagerenderer.ts
@@ -2,41 +2,28 @@ import * as mobx from "mobx";
 import {WindowSize, RendererContext, TermOptsType} from "./types";
 import {getPtyData, termWidthFromCols, termHeightFromRows} from "./model";
 import {incObs} from "./util";
-
-const InitialSize = 10*1024;
-const IncreaseFactor = 1.5;
+import {PtyDataBuffer} from "./ptydata";
 
 class ImageRendererModel {
     context : RendererContext;
-    dataSize : number;
-    imageData : Uint8Array;
-    brokenData : boolean;
     isDone : mobx.IObservableValue<boolean>;
     reloading : boolean = false;
-    dataVersion : mobx.IObservableValue<number>;
     htmlImgDivElem : any;
     htmlImg : any;
     termOpts : TermOptsType;
+    dataBuf : PtyDataBuffer;
 
     constructor(imgDivElem : any, context : RendererContext, termOpts : TermOptsType, isDone : boolean) {
+        this.dataBuf = new PtyDataBuffer();
         this.htmlImgDivElem = imgDivElem;
         this.termOpts = termOpts;
         this.context = context;
-        this._resetData();
         this.isDone = mobx.observable.box(isDone, {name: "isDone"});
-        this.dataVersion = mobx.observable.box(0, {name: "dataVersion"});
         this.reload(0);
-        console.log("image", this.termOpts);
-    }
-
-    _resetData() {
-        this.dataSize = 0;
-        this.imageData = new Uint8Array(InitialSize);
-        this.brokenData = false;
     }
 
     dispose() : void {
-        this._resetData();
+        this.dataBuf.reset();
         this.removeImage();
     }
 
@@ -49,7 +36,7 @@ class ImageRendererModel {
         if (!this.isDone.get()) {
             return;
         }
-        let blob = new Blob([this.imageData.slice(0, this.dataSize)], {type: "image/jpeg"});
+        let blob = new Blob([this.dataBuf.getData()], {type: "image/jpeg"});
         this.htmlImg = new Image();
         this.htmlImg.src = URL.createObjectURL(blob);
         this.htmlImg.style.maxHeight = termHeightFromRows(this.termOpts.rows) + "px";
@@ -61,43 +48,24 @@ class ImageRendererModel {
         if (this.reloading) {
             return;
         }
-        this._resetData();
+        this.dataBuf.reset();
         this.reloading = true;
         let rtnp = getPtyData(this.context.sessionId, this.context.cmdId);
         rtnp.then((ptydata) => {
             setTimeout(() => {
                 this.reloading = false;
-                this.receiveData(ptydata.pos, ptydata.data, "reload");
+                this.dataBuf.receiveData(ptydata.pos, ptydata.data, "reload");
                 this.renderImage();
             }, delayMs);
         }).catch((e) => {
-            this.brokenData = true;
+            this.dataBuf.brokenData = true;
             this.reloading = false;
             console.log("error reloading image data", e);
         });
     }
 
-    _growArray(minSize : number) : void {
-        let newSize = Math.round(this.imageData.length * IncreaseFactor);
-        if (newSize < minSize) {
-            newSize = minSize;
-        }
-        let newData = new Uint8Array(newSize);
-        newData.set(this.imageData);
-        this.imageData = newData;
-    }
-
     receiveData(pos : number, data : Uint8Array, reason? : string) : void {
-        if (pos != this.dataSize) {
-            this.brokenData = true;
-            return;
-        }
-        if (this.dataSize + data.length > this.imageData.length) {
-            this._growArray(this.dataSize + data.length);
-        }
-        this.imageData.set(data, pos);
-        this.dataSize += data.length;
-        incObs(this.dataVersion);
+        this.dataBuf.receiveData(pos, data, reason);
     }
 
     cmdDone() : void {
diff --git a/src/main.tsx b/src/main.tsx
index 1b33583b..ec39e28a 100644
--- a/src/main.tsx
+++ b/src/main.tsx
@@ -314,7 +314,7 @@ class ImageRenderer extends React.Component<{sw : ScreenWindow, line : LineType,
         let isLoaded = this.imageLoaded.get();
         let isDone = (imageModel != null && imageModel.isDone.get());
         if (imageModel != null) {
-            let dataVersion = imageModel.dataVersion.get();
+            let dataVersion = imageModel.dataBuf.dataVersion.get();
         }
         return (
             <div ref={this.elemRef} className={"image-wrapper"}>
diff --git a/src/ptydata.ts b/src/ptydata.ts
new file mode 100644
index 00000000..3e8ea44b
--- /dev/null
+++ b/src/ptydata.ts
@@ -0,0 +1,58 @@
+import * as mobx from "mobx";
+import {incObs} from "./util";
+
+const InitialSize = 10*1024;
+const IncreaseFactor = 1.5;
+
+class PtyDataBuffer {
+    ptyPos : number;
+    dataVersion : mobx.IObservableValue<number>;
+    brokenData : boolean;
+    rawData : Uint8Array;
+    dataSize : number;
+
+    constructor() {
+        this.ptyPos = 0;
+        this.dataVersion = mobx.observable.box(0, {name: "dataVersion"});
+        this._resetData();
+    }
+
+    _resetData() {
+        this.dataSize = 0;
+        this.rawData = new Uint8Array(InitialSize);
+        this.brokenData = false;
+    }
+
+    reset() : void {
+        this._resetData();
+    }
+
+    getData() : Uint8Array {
+        return this.rawData.slice(0, this.dataSize);
+    }
+
+    _growArray(minSize : number) : void {
+        let newSize = Math.round(this.rawData.length * IncreaseFactor);
+        if (newSize < minSize) {
+            newSize = minSize;
+        }
+        let newData = new Uint8Array(newSize);
+        newData.set(this.rawData);
+        this.rawData = newData;
+    }
+
+    receiveData(pos : number, data : Uint8Array, reason? : string) : void {
+        if (pos != this.dataSize) {
+            this.brokenData = true;
+            return;
+        }
+        if (this.dataSize + data.length > this.rawData.length) {
+            this._growArray(this.dataSize + data.length);
+        }
+        this.rawData.set(data, pos);
+        this.dataSize += data.length;
+        incObs(this.dataVersion);
+    }
+}
+
+export {PtyDataBuffer};