From 3240b128e1f8c749c98c3f5b78efd019786e0061 Mon Sep 17 00:00:00 2001 From: sawka Date: Wed, 1 Feb 2023 00:44:31 -0800 Subject: [PATCH] fix nil ptr exception (because GetType() returns a value even when pk is nil) --- pkg/shexec/shexec.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/shexec/shexec.go b/pkg/shexec/shexec.go index bfa3a541..60c6660f 100644 --- a/pkg/shexec/shexec.go +++ b/pkg/shexec/shexec.go @@ -728,6 +728,9 @@ func RunInstallFromCmd(ctx context.Context, ecmd *exec.Cmd, tryDetect bool, mshe case <-ctx.Done(): return ctx.Err() } + if pk == nil { + return fmt.Errorf("no response packet received from client") + } if pk.GetType() == packet.InitPacketStr && firstInit { firstInit = false initPacket := pk.(*packet.InitPacketType)