From 5e4b56abf4181b24e4cef1f72ea1f39314344aae Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Sat, 30 May 2026 11:19:56 +0200 Subject: [PATCH] reviews: suggest contributing missing tests upstream to GNU --- content/reviews.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/content/reviews.md b/content/reviews.md index 6e0f02073..943c5363e 100644 --- a/content/reviews.md +++ b/content/reviews.md @@ -47,6 +47,9 @@ check these before requesting a review, your PR will move much faster. tracked with `remaining-gnu-error.py`) should not go backwards; a compatibility fix should ideally add the now-passing test. Error messages and exit codes should match GNU, checked with `LANG=C` (except for locale bugs). +- If the GNU test suite passes but you still found a behavior difference, that is + a gap in their coverage: please contribute the missing test upstream to GNU to + improve their test suite. - **It updates docs, help and translations.** A new option or behavior should also update the `--help` text, the documentation, the generated man pages, and at least the English `locales/en-US.ftl` strings.