From 6e386d973a41298d759d06cfc4db5fc2c6370ae7 Mon Sep 17 00:00:00 2001 From: Tuomas Tynkkynen Date: Mon, 3 Nov 2025 00:39:49 +0200 Subject: [PATCH] ps: Fix clippy error error: implicitly cloning a `String` by calling `to_string` on its dereferenced type --> src/uu/ps/src/mapping.rs:18:39 | 18 | None => (key.clone(), mapping.get(&key).unwrap().to_string()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `mapping.get(&key).unwrap().clone()` | error: implicitly cloning a `String` by calling `to_string` on its dereferenced type --> src/uu/ps/src/ps.rs:97:40 | 97 | .map(|code| (code.clone(), default_mapping[&code].to_string())) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `default_mapping[&code].clone()` --- src/uu/ps/src/mapping.rs | 2 +- src/uu/ps/src/ps.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/uu/ps/src/mapping.rs b/src/uu/ps/src/mapping.rs index 98bec59..85070d6 100644 --- a/src/uu/ps/src/mapping.rs +++ b/src/uu/ps/src/mapping.rs @@ -15,7 +15,7 @@ pub(crate) fn collect_code_mapping(formats: &[OptionalKeyValue]) -> Vec<(String, let key = it.key().to_string(); match it.value() { Some(value) => (key, value.clone()), - None => (key.clone(), mapping.get(&key).unwrap().to_string()), + None => (key.clone(), mapping.get(&key).unwrap().clone()), } }) .collect() diff --git a/src/uu/ps/src/ps.rs b/src/uu/ps/src/ps.rs index 6704c8b..91cc30a 100644 --- a/src/uu/ps/src/ps.rs +++ b/src/uu/ps/src/ps.rs @@ -100,7 +100,7 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> { default_codes(); codes .into_iter() - .map(|code| (code.clone(), default_mapping[&code].to_string())) + .map(|code| (code.clone(), default_mapping[&code].clone())) .collect::>() } else { collect_code_mapping(&arg_formats)