From c750bffdd869a841a48ef103651f644c079105c0 Mon Sep 17 00:00:00 2001 From: naoNao89 <90588855+naoNao89@users.noreply.github.com> Date: Wed, 29 Oct 2025 15:27:21 +0700 Subject: [PATCH] fix: resolve unused import warnings in SHAKE benchmarks - Split bench_shake_algorithm macro into separate patterns for Shake128 and Shake256 - Only import the specific SHAKE type that is used in each macro invocation - Resolves CI compilation errors due to unused import warnings --- src/uu/cksum/benches/cksum_bench.rs | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/uu/cksum/benches/cksum_bench.rs b/src/uu/cksum/benches/cksum_bench.rs index 9c38042a9..ba17d5eb8 100644 --- a/src/uu/cksum/benches/cksum_bench.rs +++ b/src/uu/cksum/benches/cksum_bench.rs @@ -49,15 +49,34 @@ macro_rules! bench_algorithm { // Since SHAKE algorithms have fundamental --length parameter conflicts in cksum, // we implement them using direct digest calculation for meaningful benchmarks macro_rules! bench_shake_algorithm { - ($algo_name:ident, $algo_str:expr, $shake_type:ty) => { + ($algo_name:ident, $algo_str:expr, Shake128) => { #[divan::bench] fn $algo_name(bencher: Bencher) { - use uucore::sum::{Digest, Shake128, Shake256}; + use uucore::sum::{Digest, Shake128}; let data = text_data::generate_by_size(100, 80); bencher.bench(|| { - let mut shake = <$shake_type>::new(); + let mut shake = Shake128::new(); + shake.hash_update(&data); + + // SHAKE algorithms can output any length, use 256 bits (32 bytes) for meaningful comparison + let mut output = [0u8; 32]; + shake.hash_finalize(&mut output); + + black_box(output); + }); + } + }; + ($algo_name:ident, $algo_str:expr, Shake256) => { + #[divan::bench] + fn $algo_name(bencher: Bencher) { + use uucore::sum::{Digest, Shake256}; + + let data = text_data::generate_by_size(100, 80); + + bencher.bench(|| { + let mut shake = Shake256::new(); shake.hash_update(&data); // SHAKE algorithms can output any length, use 256 bits (32 bytes) for meaningful comparison