Dennis Zhou 13369816cb
block: fix blk-iolatency accounting underflow ...
The blk-iolatency controller measures the time from rq_qos_throttle() to
rq_qos_done_bio() and attributes this time to the first bio that needs
to create the request. This means if a bio is plug-mergeable or
bio-mergeable, it gets to bypass the blk-iolatency controller.
The recent series [1], to tag all bios w/ blkgs undermined how iolatency
was determining which bios it was charging and should process in
rq_qos_done_bio(). Because all bios are being tagged, this caused the
atomic_t for the struct rq_wait inflight count to underflow and result
in a stall.
This patch adds a new flag BIO_TRACKED to let controllers know that a
bio is going through the rq_qos path. blk-iolatency now checks if this
flag is set to see if it should process the bio in rq_qos_done_bio().
Overloading BLK_QUEUE_ENTERED works, but makes the flag rules confusing.
BIO_THROTTLED was another candidate, but the flag is set for all bios
that have gone through blk-throttle code. Overloading a flag comes with
the burden of making sure that when either implementation changes, a
change in setting rules for one doesn't cause a bug in the other. So
here, we unfortunately opt for adding a new flag.
[1] https://lore.kernel.org/lkml/20181205171039.73066-1-dennis@kernel.org/
Fixes: 5cdf2e3feadennis@kernel.org >
Cc: Josef Bacik <josef@toxicpanda.com >
Signed-off-by: Jens Axboe <axboe@kernel.dk >
2018-12-17 11:19:54 -07:00
2018-10-08 11:40:43 +02:00
2018-10-31 10:57:43 -07:00
2018-11-09 17:33:32 +01:00
2018-11-08 17:51:11 +01:00
2018-10-18 15:41:21 -07:00
2018-10-10 13:47:06 +02:00
2018-10-16 11:13:50 +02:00
2018-10-26 10:50:10 -07:00
2018-10-23 08:45:05 +01:00
2018-10-25 17:57:35 -07:00
2018-10-31 16:47:55 -07:00
2018-11-07 09:31:12 +02:00
2018-10-08 11:40:43 +02:00
2018-11-06 17:40:31 +01:00
2018-11-26 10:25:20 +01:00
2018-10-12 15:25:17 +01:00
2018-10-26 08:14:13 -07:00
2018-11-26 16:45:10 +05:30
2018-10-26 07:38:19 -07:00
2018-11-28 11:57:07 +01:00
2018-10-21 17:00:17 +01:00
2018-12-02 09:43:57 -05:00
2018-11-07 13:23:18 +01:00
2018-10-25 06:50:48 -07:00
2018-10-31 19:24:21 +01:00
2018-10-03 16:47:43 +02:00
2018-12-07 22:26:38 -07:00
2018-10-31 08:54:12 -07:00
2018-10-15 15:43:06 +02:00
2018-12-17 11:19:54 -07:00
2018-12-12 17:43:33 -07:00
2018-11-07 13:44:59 -07:00
2018-12-13 09:59:08 +01:00
2018-11-07 13:44:59 -07:00
2018-12-04 11:38:17 -07:00
2018-12-16 19:53:47 -07:00
2018-10-19 13:24:31 -07:00
2018-10-31 16:53:17 -07:00
2018-10-19 13:24:31 -07:00
2018-11-07 13:42:33 -07:00
2018-10-02 22:20:50 -04:00
2018-10-26 16:26:32 -07:00
2018-12-07 22:26:37 -07:00
2018-10-03 15:29:15 +03:00
2018-10-18 15:43:38 -07:00
2018-10-25 11:14:36 -07:00
2018-11-03 23:42:16 +01:00
2018-11-08 11:33:52 +01:00
2018-11-06 15:30:16 +01:00
2018-11-05 08:14:18 -08:00
2018-11-05 08:14:18 -08:00
2018-10-03 16:47:43 +02:00
2018-11-02 19:39:54 +01:00
2018-10-04 10:23:37 +02:00
2018-10-06 12:09:26 +02:00
2018-10-08 22:53:10 +11:00
2018-12-04 21:32:00 -08:00
2018-10-19 07:53:18 +02:00
2018-10-26 16:26:32 -07:00
2018-10-26 12:57:38 -07:00
2018-10-26 08:42:25 -07:00
2018-10-08 09:44:17 +02:00
2018-11-21 18:47:52 +01:00
2018-10-09 15:08:26 +02:00
2018-10-04 09:40:52 -07:00
2018-11-15 10:04:46 +01:00
2018-11-07 13:42:32 -07:00
2018-10-22 17:54:47 -07:00
2018-10-08 13:48:45 +02:00
2018-11-30 17:04:35 -08:00
2018-11-19 19:03:50 -07:00
2018-11-28 13:19:20 +00:00
2018-10-04 13:28:02 +02:00
2018-11-27 20:31:54 -05:00
2018-12-10 08:30:38 -07:00
2018-12-08 10:26:20 -08:00
2018-11-16 11:42:12 +00:00
2018-11-22 08:57:38 +01:00
2018-10-31 08:54:12 -07:00
2018-10-26 16:38:15 -07:00
2018-10-05 16:32:04 -07:00
2018-10-05 10:16:56 +08:00
2018-10-10 20:37:13 -07:00
2018-12-03 08:01:01 +01:00
2018-11-04 11:04:46 +01:00
2018-11-10 08:03:52 -07:00
2018-10-21 10:46:33 -04:00
2018-10-11 16:01:00 +02:00
2018-10-29 20:26:06 -07:00
2018-11-07 13:42:32 -07:00
2018-11-05 12:16:27 +01:00
2018-10-26 16:25:18 -07:00
2018-10-10 18:09:37 +02:00
2018-11-19 19:03:46 -07:00
2018-10-26 09:30:46 +01:00
2018-10-26 09:30:46 +01:00
2018-10-11 21:55:58 +02:00
2018-12-11 12:22:35 -07:00
2018-10-26 16:25:18 -07:00
2018-10-10 15:20:54 -05:00
2018-10-09 09:56:33 +02:00
2018-10-24 11:49:35 +01:00
2018-10-26 16:25:19 -07:00
2018-10-31 08:54:16 -07:00
2018-10-26 16:26:35 -07:00
2018-10-31 08:54:17 -07:00
2018-12-05 15:45:54 -08:00
2018-10-17 12:18:16 -05:00
2018-10-19 17:02:23 -07:00
2018-11-09 06:30:44 -06:00
2018-10-26 16:25:19 -07:00
2018-10-31 08:54:14 -07:00
2018-10-24 11:49:35 +01:00
2018-10-16 00:13:39 -07:00
2018-10-17 13:56:58 -07:00
2018-11-22 11:36:54 -08:00
2018-11-03 15:40:01 -07:00
2018-10-16 00:13:12 -07:00
2018-10-19 17:01:43 -07:00
2018-11-06 21:58:00 +01:00
2018-11-03 10:09:37 -07:00
2018-12-07 22:26:57 -07:00
2018-12-13 09:58:57 +01:00
2018-12-13 09:59:01 +01:00
2018-10-29 10:42:20 -07:00
2018-10-26 16:26:34 -07:00
2018-10-21 10:46:35 -04:00
2018-10-21 10:46:39 -04:00
2018-10-25 06:50:48 -07:00
2018-10-10 15:47:00 -05:00
2018-10-17 12:18:17 -05:00
2018-10-25 06:50:48 -07:00
2018-10-31 08:54:14 -07:00
2018-10-26 16:26:35 -07:00
2018-10-18 12:25:10 +02:00
2018-10-08 22:53:10 +11:00
2018-10-03 16:47:43 +02:00
2018-10-26 16:26:32 -07:00
2018-11-30 14:56:14 -08:00
2018-10-22 07:11:58 -07:00
2018-11-29 13:46:43 -08:00
2018-11-28 11:57:11 +01:00
2018-10-11 15:28:04 +01:00
2018-10-13 20:31:37 +03:00
2018-10-21 10:46:48 -04:00
2018-10-31 08:54:13 -07:00
2018-10-21 12:07:26 +01:00
2018-10-19 12:53:55 -07:00
2018-10-04 11:36:07 +02:00
2018-12-03 17:03:58 -07:00
2018-12-01 12:35:48 -08:00
2018-10-03 16:47:43 +02:00
2018-10-04 09:57:45 -07:00
2018-10-02 14:38:02 -07:00
2018-11-29 11:46:34 -08:00
2018-10-03 16:50:39 +02:00
2018-10-31 08:54:14 -07:00
2018-12-13 09:58:55 +01:00
2018-10-20 21:37:11 +02:00
2018-10-26 16:26:31 -07:00
2018-10-09 16:51:11 +02:00
2018-10-09 11:20:55 +02:00
2018-10-11 12:12:55 +02:00
2018-10-12 12:35:02 +02:00
2018-10-28 11:35:40 -07:00
2018-10-19 08:48:28 +02:00
2018-10-11 09:16:44 -07:00
2018-11-21 15:49:52 -08:00
2018-10-02 15:52:08 -07:00
2018-10-25 11:14:36 -07:00
2018-10-10 22:14:17 -04:00
2018-11-12 04:53:27 +01:00
2018-10-17 15:35:29 -04:00
2018-11-29 22:08:38 -05:00
2018-10-13 00:50:53 -04:00
2018-12-05 11:29:10 +01:00
2018-12-13 09:58:54 +01:00
2018-10-22 19:37:36 -07:00
2018-12-05 21:20:14 +01:00
2018-10-04 22:23:15 -07:00
2018-10-16 00:11:13 -04:00
2018-12-07 22:26:37 -07:00
2018-11-05 16:38:10 -05:00
Dennis Zhou
13369816cb