Eric W. Biederman c61a2810a2
userns: Avoid recursion in put_user_ns ...
When freeing a deeply nested user namespace free_user_ns calls
put_user_ns on it's parent which may in turn call free_user_ns again.
When -fno-optimize-sibling-calls is passed to gcc one stack frame per
user namespace is left on the stack, potentially overflowing the
kernel stack. CONFIG_FRAME_POINTER forces -fno-optimize-sibling-calls
so we can't count on gcc to optimize this code.
Remove struct kref and use a plain atomic_t. Making the code more
flexible and easier to comprehend. Make the loop in free_user_ns
explict to guarantee that the stack does not overflow with
CONFIG_FRAME_POINTER enabled.
I have tested this fix with a simple program that uses unshare to
create a deeply nested user namespace structure and then calls exit.
With 1000 nesteuser namespaces before this change running my test
program causes the kernel to die a horrible death. With 10,000,000
nested user namespaces after this change my test program runs to
completion and causes no harm.
Acked-by: Serge Hallyn <serge.hallyn@canonical.com >
Pointed-out-by: Vasily Kulikov <segoon@openwall.com >
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com >
2013-01-26 22:11:41 -08:00
2012-12-03 11:15:35 +00:00
2012-12-19 12:47:41 -08:00
2012-12-20 14:00:13 -08:00
2012-12-14 14:54:26 -08:00
2012-12-18 16:51:10 -08:00
2012-11-20 21:28:51 +00:00
2012-12-18 12:46:37 -08:00
2012-12-14 14:42:53 -08:00
2012-12-16 18:55:20 -08:00
2012-12-19 11:47:22 -08:00
2012-12-11 11:19:09 -08:00
2012-12-03 16:36:52 +02:00
2012-11-30 12:01:30 -05:00
2012-11-21 08:55:26 +01:00
2012-12-20 10:07:25 -08:00
2012-12-13 19:26:04 -08:00
2012-12-13 19:51:03 +11:00
2012-12-10 12:43:22 +09:00
2012-12-07 17:02:47 +00:00
2012-12-14 14:27:45 -08:00
2012-12-20 14:04:11 -08:00
2012-12-19 12:46:40 -08:00
2012-11-30 12:37:36 +01:00
2012-12-14 10:03:23 -08:00
2012-12-14 13:06:41 +10:30
2012-12-03 05:15:33 -05:00
2012-12-14 09:34:01 -05:00
2012-12-10 15:49:57 -05:00
2012-12-02 00:05:12 +00:00
2012-11-20 18:18:52 +09:00
2012-12-17 11:29:09 -08:00
2012-12-17 17:15:16 -08:00
2012-12-11 17:22:26 -08:00
2012-12-06 14:58:56 -05:00
2012-12-20 20:00:43 -08:00
2012-12-19 07:18:35 -08:00
2012-12-12 17:38:35 -08:00
2012-12-06 14:33:02 +01:00
2012-11-26 17:41:24 -08:00
2012-11-20 06:44:58 -08:00
2012-12-11 11:25:08 -08:00
2012-12-20 18:05:28 -08:00
2012-12-19 07:55:08 -08:00
2012-12-06 01:22:31 +00:00
2012-12-19 07:55:08 -08:00
2012-11-30 11:40:07 -08:00
2012-11-29 00:01:25 -05:00
2012-11-22 15:59:52 +08:00
2012-12-12 17:38:32 -08:00
2012-12-17 15:44:47 -08:00
2012-12-20 13:57:36 -05:00
2012-11-26 19:17:44 +09:00
2012-12-21 20:23:41 +00:00
2012-12-14 09:59:59 -08:00
2012-11-29 03:30:34 -08:00
2012-12-20 12:05:06 +05:30
2012-12-11 09:28:09 +01:00
2012-11-28 11:54:40 +01:00
2012-12-15 15:20:41 -08:00
2012-12-20 14:04:11 -08:00
2012-11-22 13:43:27 +09:00
2012-12-11 13:43:45 +09:00
2012-11-28 21:49:02 -05:00
2012-12-12 08:18:24 -08:00
2012-11-28 21:49:02 -05:00
2012-12-20 18:49:14 -05:00
2012-12-20 22:34:00 +00:00
2012-12-20 22:04:07 +00:00
2012-11-26 13:41:19 -06:00
2012-12-11 13:44:36 -05:00
2012-12-17 17:15:12 -08:00
2012-11-23 14:28:53 +01:00
2012-12-18 15:02:12 -08:00
2012-11-21 10:07:48 +01:00
2012-12-06 10:39:54 +01:00
2012-12-12 16:49:10 +01:00
2012-12-12 21:41:55 +01:00
2012-12-16 15:18:08 -08:00
2012-12-18 15:02:15 -08:00
2012-12-16 15:18:08 -08:00
2012-11-19 22:21:03 +00:00
2012-11-28 11:36:32 +01:00
2012-11-23 12:23:40 +01:00
2012-12-06 14:02:51 +01:00
2012-12-14 13:05:26 +10:30
2012-12-04 13:08:10 -05:00
2012-12-17 17:15:12 -08:00
2012-12-09 00:20:28 -05:00
2012-11-21 15:09:26 -08:00
2012-11-20 04:19:49 -08:00
2012-12-09 00:20:28 -05:00
2012-12-13 14:20:19 -08:00
2012-11-19 16:41:21 +01:00
2012-12-20 17:40:20 -08:00
2012-12-16 15:40:50 -08:00
2012-11-28 10:33:03 -08:00
2012-11-20 16:15:02 +10:00
2012-12-13 15:31:08 -08:00
2012-11-26 14:28:51 -08:00
2012-12-03 05:15:17 -05:00
2012-11-30 11:48:05 +01:00
2012-12-17 13:39:11 -08:00
2012-12-18 15:02:15 -08:00
2012-12-11 17:22:28 -08:00
2012-12-12 17:38:33 -08:00
2012-12-16 15:18:08 -08:00
2012-11-23 14:29:51 -05:00
2012-12-16 15:18:08 -08:00
2012-12-01 10:07:54 +00:00
2012-12-18 10:56:07 -08:00
2012-12-20 18:46:29 -05:00
2012-12-16 15:18:08 -08:00
2012-12-14 13:06:40 +10:30
2012-12-20 18:50:02 -05:00
2012-12-13 12:00:02 -08:00
2012-12-06 00:30:46 +01:00
2012-12-15 15:21:52 -05:00
2012-12-11 17:22:27 -08:00
2012-12-12 17:38:34 -08:00
2012-11-20 04:18:14 -08:00
2012-11-23 22:01:15 +00:00
2012-12-11 17:30:16 +00:00
2012-12-19 16:15:17 +00:00
2012-12-18 09:58:09 -08:00
2012-11-30 08:41:50 -08:00
2012-11-20 10:04:29 -08:00
2012-12-11 17:22:27 -08:00
2012-11-26 11:33:18 -08:00
2012-12-11 17:22:22 -08:00
2012-12-11 17:22:26 -08:00
2012-11-21 16:31:17 -08:00
2012-12-13 12:14:47 -08:00
2012-12-17 17:15:18 -08:00
2012-12-25 16:10:05 -08:00
2012-12-25 16:10:05 -08:00
2012-11-21 00:21:59 +01:00
2012-12-17 20:58:12 -08:00
2012-11-26 16:07:44 -08:00
2012-12-20 18:05:28 -08:00
2012-11-27 23:29:12 -02:00
2012-11-22 22:47:12 +01:00
2012-12-17 17:15:26 -08:00
2012-11-30 11:40:07 -08:00
2012-12-11 12:39:32 +09:00
2012-12-18 15:02:12 -08:00
2012-12-11 14:43:00 +00:00
2012-12-20 18:05:28 -08:00
2012-12-14 13:05:24 +10:30
2012-12-11 17:22:25 -08:00
2012-12-19 18:07:41 -05:00
2012-12-09 00:20:28 -05:00
2012-12-18 15:02:13 -08:00
2012-12-18 15:02:14 -08:00
2012-12-18 15:02:14 -08:00
2012-12-07 12:48:00 -05:00
2012-12-13 12:00:02 -08:00
2012-12-17 17:15:17 -08:00
2012-12-20 18:05:28 -08:00
2012-12-09 00:20:28 -05:00
2012-12-12 15:34:48 +08:00
2012-12-18 15:02:13 -08:00
2012-12-11 17:22:27 -08:00
2012-12-09 00:20:28 -05:00
2013-01-26 22:11:41 -08:00
2012-11-20 04:19:49 -08:00
2012-12-18 15:20:43 +10:30
2012-12-16 15:18:08 -08:00
2012-12-11 14:42:48 +00:00
2012-11-19 16:41:21 +01:00
2012-11-30 11:47:57 +01:00
2012-12-19 22:24:55 +01:00
2012-12-11 17:22:21 -08:00
Eric W. Biederman
c61a2810a2