Yonghong Song b910eaaaa4
bpf: Fix NULL pointer dereference in bpf_get_local_storage() helper ...
Jiri Olsa reported a bug ([1]) in kernel where cgroup local
storage pointer may be NULL in bpf_get_local_storage() helper.
There are two issues uncovered by this bug:
(1). kprobe or tracepoint prog incorrectly sets cgroup local storage
before prog run,
(2). due to change from preempt_disable to migrate_disable,
preemption is possible and percpu storage might be overwritten
by other tasks.
This issue (1) is fixed in [2]. This patch tried to address issue (2).
The following shows how things can go wrong:
task 1: bpf_cgroup_storage_set() for percpu local storage
preemption happens
task 2: bpf_cgroup_storage_set() for percpu local storage
preemption happens
task 1: run bpf program
task 1 will effectively use the percpu local storage setting by task 2
which will be either NULL or incorrect ones.
Instead of just one common local storage per cpu, this patch fixed
the issue by permitting 8 local storages per cpu and each local
storage is identified by a task_struct pointer. This way, we
allow at most 8 nested preemption between bpf_cgroup_storage_set()
and bpf_cgroup_storage_unset(). The percpu local storage slot
is released (calling bpf_cgroup_storage_unset()) by the same task
after bpf program finished running.
bpf_test_run() is also fixed to use the new bpf_cgroup_storage_set()
interface.
The patch is tested on top of [2] with reproducer in [1].
Without this patch, kernel will emit error in 2-3 minutes.
With this patch, after one hour, still no error.
[1] https://lore.kernel.org/bpf/CAKH8qBuXCfUz=w8L+Fj74OaUpbosO29niYwTki7e3Ag044_aww@mail.gmail.com/T
[2] https://lore.kernel.org/bpf/20210309185028.3763817-1-yhs@fb.com
Signed-off-by: Yonghong Song <yhs@fb.com >
Signed-off-by: Alexei Starovoitov <ast@kernel.org >
Acked-by: Roman Gushchin <guro@fb.com >
Link: https://lore.kernel.org/bpf/20210323055146.3334476-1-yhs@fb.com
2021-03-25 18:31:36 -07:00
2021-03-16 10:39:28 -06:00
2021-03-22 11:32:12 -07:00
2021-03-01 11:45:04 +01:00
2021-02-16 12:09:52 +01:00
2021-02-22 09:45:23 -08:00
2021-02-09 12:26:40 +01:00
2021-02-01 11:29:11 +05:30
2021-03-16 15:49:52 -07:00
2021-02-24 10:25:37 -08:00
2021-01-27 15:13:52 +01:00
2021-03-08 11:59:17 +01:00
2021-02-02 00:16:57 +01:00
2021-02-15 21:28:53 +01:00
2021-02-24 10:35:29 -08:00
2021-03-25 15:31:22 -07:00
2021-02-08 12:53:34 +01:00
2021-02-05 15:24:59 +02:00
2021-03-15 18:42:01 +01:00
2021-03-15 12:53:12 -07:00
2021-03-22 18:02:10 -07:00
2021-03-22 13:00:49 -07:00
2021-03-10 12:22:26 +00:00
2021-01-23 14:57:21 +01:00
2021-03-13 11:27:30 -08:00
2021-02-21 14:44:44 -08:00
2021-03-02 15:33:00 +01:00
2021-02-22 09:27:18 -08:00
2021-02-08 13:23:42 +02:00
2021-03-11 15:26:07 -05:00
2021-02-25 10:17:31 -08:00
2021-03-08 11:59:17 +01:00
2021-01-20 12:31:43 +00:00
2021-03-08 15:16:30 -08:00
2021-02-15 18:28:30 +01:00
2021-03-11 07:47:48 -07:00
2021-02-26 09:41:04 -08:00
2021-02-08 08:33:16 -07:00
2021-02-10 16:38:02 +01:00
2021-03-01 10:15:07 -07:00
2021-02-23 09:54:51 -07:00
2021-02-26 11:51:48 -08:00
2021-02-26 11:51:47 -08:00
2021-02-26 12:28:03 -08:00
2021-02-26 13:23:52 -08:00
2021-03-25 18:31:36 -07:00
2021-03-25 18:31:36 -07:00
2021-02-16 15:23:23 -08:00
2021-03-17 18:45:40 -07:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:03 -08:00
2021-02-17 14:07:48 +01:00
2021-02-14 12:37:48 -08:00
2021-02-22 09:45:23 -08:00
2021-02-14 18:15:15 +00:00
2021-03-13 11:27:30 -08:00
2021-02-16 12:01:32 +09:00
2021-03-11 14:40:50 +09:00
2021-01-22 11:08:56 +01:00
2021-01-21 14:06:00 -07:00
2021-02-11 18:31:48 +01:00
2021-02-04 17:00:32 +01:00
2021-03-10 09:16:09 +01:00
2021-02-04 19:25:47 +01:00
2021-02-28 12:06:45 -08:00
2021-02-26 09:41:03 -08:00
2021-01-22 14:58:01 +11:00
2021-02-04 16:36:28 +05:30
2021-02-11 09:45:28 -05:00
2021-02-26 13:59:32 -08:00
2021-01-18 14:26:51 +01:00
2021-02-24 21:05:28 +05:30
2021-02-24 21:04:54 +05:30
2021-02-24 09:54:24 -08:00
2021-02-26 13:59:32 -08:00
2021-02-04 14:42:00 +01:00
2021-01-20 18:52:12 +01:00
2021-03-19 07:44:28 +01:00
2021-01-24 18:19:46 -07:00
2021-02-17 14:12:42 +01:00
2021-02-17 14:12:43 +01:00
2021-03-14 14:48:02 -07:00
2021-03-17 11:42:30 -07:00
2021-02-16 09:59:41 +01:00
2021-02-08 12:28:07 +01:00
2021-01-30 11:47:12 -05:00
2021-01-27 15:20:02 -08:00
2021-03-10 01:06:34 +01:00
2021-02-26 09:41:04 -08:00
2021-02-24 13:38:28 -08:00
2021-02-07 14:51:11 -08:00
2021-02-09 12:43:42 -05:00
2021-02-24 10:13:55 -08:00
2021-01-24 18:17:20 -07:00
2021-02-26 09:40:59 -08:00
2021-01-26 14:24:26 +01:00
2021-01-22 08:52:02 +00:00
2021-01-26 14:24:26 +01:00
2021-02-24 13:38:32 -08:00
2021-02-11 19:56:15 +01:00
2021-02-24 13:38:32 -08:00
2021-03-25 09:22:55 -07:00
2021-02-24 13:38:35 -08:00
2021-02-15 10:49:11 +00:00
2021-02-23 11:29:52 -08:00
2021-03-23 14:49:05 -07:00
2021-02-11 13:24:44 -08:00
2021-03-10 15:20:24 -08:00
2021-03-15 20:41:58 -07:00
2021-02-23 13:39:45 -08:00
2021-02-16 13:14:06 -08:00
2021-02-26 09:41:05 -08:00
2021-02-18 23:17:57 -08:00
2021-02-04 14:42:00 +01:00
2021-02-10 23:34:16 +01:00
2021-03-18 09:44:35 -06:00
2021-02-12 15:27:17 +01:00
2021-02-21 10:29:20 -08:00
2021-02-12 15:27:17 +01:00
2021-01-27 12:27:36 +01:00
2021-02-23 11:29:52 -08:00
2021-02-05 20:48:28 +01:00
2021-03-08 20:12:08 +00:00
2021-01-22 11:08:56 +01:00
2021-01-26 07:42:27 +01:00
2021-01-22 11:08:56 +01:00
2021-02-08 12:24:04 +01:00
2021-02-24 13:38:31 -08:00
2021-02-26 09:41:03 -08:00
2021-03-11 14:40:50 +09:00
2021-02-17 14:12:42 +01:00
2021-02-26 10:19:03 -08:00
2021-01-21 16:16:10 +00:00
2021-02-22 10:22:54 -08:00
2021-02-26 09:41:02 -08:00
2021-02-26 09:41:05 -08:00
2021-02-26 09:40:59 -08:00
2021-01-29 15:39:48 -05:00
2021-02-26 09:41:03 -08:00
2021-01-22 15:09:42 +01:00
2021-02-22 13:16:53 -05:00
2021-02-19 11:54:08 +01:00
2021-02-19 11:54:08 +01:00
2021-02-19 11:35:28 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-03-15 14:50:28 -07:00
2021-02-26 09:41:03 -08:00
2021-01-19 12:02:20 -08:00
2021-01-19 11:47:31 -08:00
2021-02-09 09:30:16 +01:00
2021-03-25 09:22:55 -07:00
2021-03-13 11:27:31 -08:00
2021-02-26 09:41:00 -08:00
2021-02-26 09:41:00 -08:00
2021-02-26 09:41:00 -08:00
2021-01-27 16:45:59 +05:30
2021-02-24 13:38:35 -08:00
2021-02-24 13:38:33 -08:00
2021-03-13 11:27:30 -08:00
2021-03-25 09:22:55 -07:00
2021-03-25 09:22:55 -07:00
2021-02-26 09:41:00 -08:00
2021-02-24 10:25:37 -08:00
2021-03-17 13:16:18 -07:00
2021-02-27 08:07:12 -08:00
2021-01-30 01:22:31 +01:00
2021-02-10 14:44:40 +01:00
2021-02-16 19:35:29 -08:00
2021-02-23 20:32:11 -07:00
2021-02-11 13:24:44 -08:00
2021-03-25 15:31:22 -07:00
2021-01-25 22:06:11 +01:00
2021-02-04 18:05:59 -08:00
2021-02-16 16:11:14 -05:00
2021-02-26 09:17:24 -08:00
2021-01-25 09:36:27 -05:00
2021-02-02 10:26:12 +01:00
2021-01-26 11:12:00 -06:00
2021-02-12 19:23:57 -06:00
2021-02-11 08:33:41 +01:00
2021-02-17 13:17:49 -08:00
2021-02-24 13:38:29 -08:00
2021-02-26 09:41:01 -08:00
2021-03-23 20:54:29 +00:00
2021-02-26 09:40:59 -08:00
2021-01-21 14:06:00 -07:00
2021-02-03 19:05:50 +01:00
2021-02-25 09:56:08 -08:00
2021-02-23 14:11:13 -06:00
2021-02-23 14:12:01 -06:00
2021-02-23 09:28:51 -08:00
2021-03-06 12:52:39 +01:00
2021-03-10 10:56:46 +00:00
2021-03-24 15:20:07 -07:00
2021-03-15 12:53:12 -07:00
2021-02-24 14:52:41 +01:00
2021-01-22 17:08:28 +01:00
2021-02-04 16:30:14 +05:30
2021-01-27 19:29:32 +01:00
2021-01-27 17:44:18 -08:00
2021-01-24 14:27:17 +01:00
2021-01-24 14:27:20 +01:00
2021-03-24 12:48:38 -07:00
2021-03-10 15:25:02 +01:00
2021-02-04 05:27:20 -05:00
2021-03-12 17:09:34 -08:00
2021-02-26 09:41:03 -08:00
2021-02-17 14:07:44 +01:00
2021-02-21 12:35:04 -08:00
2021-01-25 17:32:10 +01:00
2021-03-16 22:13:11 +01:00
2021-02-26 09:41:01 -08:00
2021-02-04 05:27:42 -05:00
2021-03-09 18:07:05 -08:00
2021-02-23 13:39:45 -08:00
2021-03-10 09:51:45 +01:00
2021-03-25 15:31:22 -07:00
2021-02-26 12:28:04 -08:00
2021-02-26 09:41:02 -08:00
2021-01-22 15:16:01 -08:00
2021-02-26 09:41:02 -08:00
2021-03-16 15:52:15 -07:00
2021-01-18 21:39:28 +01:00
2021-02-26 09:41:04 -08:00
2021-02-17 14:12:42 +01:00
2021-02-17 14:12:42 +01:00
2021-03-24 17:58:13 -07:00
2021-03-13 11:27:30 -08:00
2021-02-26 09:41:04 -08:00
2021-03-02 17:25:46 -07:00
2021-02-20 10:13:32 -05:00
2021-02-23 13:39:45 -08:00
2021-01-22 18:20:52 -08:00
2021-02-02 14:50:15 +01:00
2021-03-01 15:25:24 -08:00
2021-01-19 22:31:10 +01:00
2021-03-16 22:13:10 +01:00
2021-02-04 10:45:24 +03:00
2021-01-27 17:26:42 +01:00
2021-02-16 10:40:28 +02:00
2021-03-04 09:51:50 -05:00
2021-02-02 17:02:05 -05:00
2021-02-09 12:27:29 -05:00
2021-01-20 16:48:47 -08:00
2021-02-20 21:28:04 -08:00
2021-02-13 17:17:53 +01:00
2021-03-10 09:51:45 +01:00
2021-02-04 18:56:56 -08:00
2021-02-15 18:50:01 +01:00
2021-03-17 21:30:15 +01:00
2021-03-11 11:11:33 +01:00
2021-03-19 22:23:19 +01:00
2021-02-25 14:26:00 -05:00
2021-01-21 16:16:10 +00:00
2021-02-01 13:20:07 -07:00
2021-03-09 16:12:20 -08:00
2021-02-23 07:52:58 -05:00
2021-03-14 04:37:35 -04:00
2021-02-12 12:56:55 +01:00
2021-02-09 12:15:07 +01:00
2021-02-26 09:41:00 -08:00
2021-01-26 19:18:50 +01:00
2021-01-21 14:06:00 -07:00
2021-01-19 10:20:07 -05:00
2021-03-17 09:56:45 +01:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:01 -08:00
2021-02-26 09:41:01 -08:00
2021-02-08 22:58:55 +01:00
Yonghong Song
b910eaaaa4