Files
kernel/include/linux
Tejun Heo 4d59b6ccf0 cpumask: use nr_cpumask_bits for parsing functions
Commit 513e3d2d11 ("cpumask: always use nr_cpu_ids in formatting and
parsing functions") converted both cpumask printing and parsing
functions to use nr_cpu_ids instead of nr_cpumask_bits.  While this was
okay for the printing functions as it just picked one of the two output
formats that we were alternating between depending on a kernel config,
doing the same for parsing wasn't okay.

nr_cpumask_bits can be either nr_cpu_ids or NR_CPUS.  We can always use
nr_cpu_ids but that is a variable while NR_CPUS is a constant, so it can
be more efficient to use NR_CPUS when we can get away with it.
Converting the printing functions to nr_cpu_ids makes sense because it
affects how the masks get presented to userspace and doesn't break
anything; however, using nr_cpu_ids for parsing functions can
incorrectly leave the higher bits uninitialized while reading in these
masks from userland.  As all testing and comparison functions use
nr_cpumask_bits which can be larger than nr_cpu_ids, the parsed cpumasks
can erroneously yield false negative results.

This made the taskstats interface incorrectly return -EINVAL even when
the inputs were correct.

Fix it by restoring the parse functions to use nr_cpumask_bits instead
of nr_cpu_ids.

Link: http://lkml.kernel.org/r/20170206182442.GB31078@htj.duckdns.org
Fixes: 513e3d2d11 ("cpumask: always use nr_cpu_ids in formatting and parsing functions")
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Martin Steigerwald <martin.steigerwald@teamix.de>
Debugged-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: <stable@vger.kernel.org>	[4.0+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2017-02-08 15:41:43 -08:00
..
2016-11-17 23:19:00 +01:00
2016-12-22 22:58:37 -05:00
2016-10-19 14:34:36 -04:00
2017-01-13 15:17:04 -07:00
2016-12-08 13:31:11 -05:00
2016-10-25 11:08:28 +08:00
2016-12-08 16:37:33 -08:00
2016-10-07 18:46:30 -07:00
2016-12-05 19:01:16 -05:00
2016-10-28 08:48:16 -06:00
2016-11-25 10:15:13 -08:00
2016-12-05 19:01:16 -05:00
2017-01-16 14:03:31 -05:00
2016-12-25 17:21:22 +01:00
2016-12-25 17:21:22 +01:00
2016-11-30 14:36:01 +11:00
2016-12-12 18:55:06 -08:00
2016-12-25 17:21:23 +01:00
2016-12-06 11:05:46 +01:00
2016-11-16 18:32:02 -05:00
2016-12-19 17:29:44 -05:00
2016-12-12 18:55:07 -08:00
2016-11-10 17:03:35 +01:00
2016-12-06 10:17:03 +02:00
2016-10-31 16:18:30 -04:00
2016-10-14 11:36:59 -07:00
2016-11-15 16:34:27 -08:00
2016-10-31 15:45:18 -07:00
2017-01-10 18:31:55 -08:00
2016-12-25 17:21:22 +01:00
2017-01-10 18:31:55 -08:00
2016-12-09 22:12:21 -05:00
2016-12-12 18:55:08 -08:00
2016-12-25 17:21:22 +01:00